Skip to content

.Net MEVD: Fix String mapping for SQL Server connector#11005

Merged
adamsitnik merged 3 commits intomicrosoft:mainfrom
adamsitnik:sqlStringSize
Mar 18, 2025
Merged

.Net MEVD: Fix String mapping for SQL Server connector#11005
adamsitnik merged 3 commits intomicrosoft:mainfrom
adamsitnik:sqlStringSize

Conversation

@adamsitnik
Copy link
Member

fixes #10975

@adamsitnik adamsitnik requested a review from a team as a code owner March 17, 2025 14:25
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel memory labels Mar 17, 2025
@roji
Copy link
Member

roji commented Mar 17, 2025

@adamsitnik shouldn't this target the feature-vector-data-preb2 branch?

@adamsitnik
Copy link
Member Author

@adamsitnik shouldn't this target the feature-vector-data-preb2 branch?

It's more like a bug fix to me and I believe the sooner we release the patch, the better (so users don't create a bunch of VARCHAR(255) columns in the upcoming month).

@roji What do you think?

@roji
Copy link
Member

roji commented Mar 18, 2025

It's more like a bug fix to me and I believe the sooner we release the patch, the better (so users don't create a bunch of VARCHAR(255) columns in the upcoming month).

Yeah, I think that makes sense. Good call.

@adamsitnik adamsitnik enabled auto-merge March 18, 2025 09:22
@adamsitnik adamsitnik added this pull request to the merge queue Mar 18, 2025
Merged via the queue into microsoft:main with commit 550648b Mar 18, 2025
20 checks passed
jcruzmot-te pushed a commit to thousandeyes/aia-semantic-kernel that referenced this pull request Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kernel Issues or pull requests impacting the core kernel memory .NET Issue or Pull requests regarding .NET code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[MEVD] [SQL Server] String mapping to nvarchar(255) vs. nvarchar(max)

5 participants