Enabling API key auth in Copilot FE#1072
Merged
hathind-ms merged 10 commits intomicrosoft:mainfrom May 18, 2023
Merged
Conversation
hathind-ms
previously approved these changes
May 18, 2023
glahaye
reviewed
May 18, 2023
samples/apps/copilot-chat-app/webapp/src/libs/services/BaseService.ts
Outdated
Show resolved
Hide resolved
…ng/semantic-kernel into adding-api-key-to-env
glahaye
suggested changes
May 18, 2023
glahaye
approved these changes
May 18, 2023
glahaye
suggested changes
May 18, 2023
Contributor
glahaye
left a comment
There was a problem hiding this comment.
Actually, there is one more reference to x-api-key (as opposed to x-sk-api-key) in the README.
Could you change that too?
glahaye
approved these changes
May 18, 2023
hathind-ms
approved these changes
May 18, 2023
shawncal
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
May 19, 2023
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> This PRs adds a new variable to the .env file called SK_API_KEY. If it is present and not blank, pass its value with all requests to the Semantic Kernel server as the value of a header named `x-sk-api-key`  ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [X] The code builds clean without any errors or warnings - [X] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [X] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [X] All unit tests pass, and I have added new tests where possible - [X] I didn't break anyone 😄 --------- Co-authored-by: Gil LaHaye <gillahaye@microsoft.com>
golden-aries
pushed a commit
to golden-aries/semantic-kernel
that referenced
this pull request
Oct 10, 2023
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> This PRs adds a new variable to the .env file called SK_API_KEY. If it is present and not blank, pass its value with all requests to the Semantic Kernel server as the value of a header named `x-sk-api-key`  ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [X] The code builds clean without any errors or warnings - [X] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [X] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [X] All unit tests pass, and I have added new tests where possible - [X] I didn't break anyone 😄 --------- Co-authored-by: Gil LaHaye <gillahaye@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PRs adds a new variable to the .env file called SK_API_KEY.
If it is present and not blank, pass its value with all requests to the Semantic Kernel server as the value of a header named
x-sk-api-keyContribution Checklist
dotnet format