Skip to content

Fix delegate_inference.py#1054

Merged
lemillermicrosoft merged 2 commits intomicrosoft:mainfrom
salmon131:main
May 19, 2023
Merged

Fix delegate_inference.py#1054
lemillermicrosoft merged 2 commits intomicrosoft:mainfrom
salmon131:main

Conversation

@salmon131
Copy link
Contributor

Motivation and Context

#691
#1053

Description

  1. Added an argument to prevent TypeError when inferring an unknown type.
  2. Fixed a bug in the process of checking parameters when inferring the InStringAndContext type.

Contribution Checklist

@github-actions github-actions bot added the python Pull requests for the Python Semantic Kernel label May 18, 2023
@alexchaomander alexchaomander added the PR: ready to merge PR has been approved by all reviewers, and is ready to merge. label May 19, 2023
@alexchaomander alexchaomander self-requested a review May 19, 2023 14:36
Copy link
Contributor

@alexchaomander alexchaomander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this fix!

@lemillermicrosoft lemillermicrosoft enabled auto-merge (squash) May 19, 2023 18:24
@lemillermicrosoft lemillermicrosoft enabled auto-merge (squash) May 19, 2023 18:24
@lemillermicrosoft lemillermicrosoft merged commit a3d2224 into microsoft:main May 19, 2023
shawncal pushed a commit to shawncal/semantic-kernel that referenced this pull request Jul 6, 2023
### Motivation and Context
microsoft#691 
microsoft#1053 

### Description
1. Added an argument to prevent TypeError when inferring an unknown
type.
2. Fixed a bug in the process of checking parameters when inferring the
InStringAndContext type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: ready to merge PR has been approved by all reviewers, and is ready to merge. python Pull requests for the Python Semantic Kernel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants