Skip to content

Update Readme.md and documentation with helpful info#434

Merged
derrickstolee merged 3 commits intomicrosoft:mainfrom
derrickstolee:readme
Sep 21, 2020
Merged

Update Readme.md and documentation with helpful info#434
derrickstolee merged 3 commits intomicrosoft:mainfrom
derrickstolee:readme

Conversation

@derrickstolee
Copy link
Contributor

@derrickstolee derrickstolee commented Sep 17, 2020

Our Readme.md file is not incredibly helpful. We have changed a lot about our install/upgrade strategy, particularly for macOS. I have fielded several questions about this over email or in issues (e.g. #399).

This PR is a start to revamping our documentation a bit. The Readme now points to the more involved docs/index.md. That directory also gets a "Philosophy of Scalar" document, which I will point to people who are wondering if Scalar is right for them.

You can see how this Readme looks at the front page of a repo by looking at my fork.

Resolves #384.

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Copy link
Contributor

@jeffhostetler jeffhostetler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a few suggestions, but very nice! Thanks!

@derrickstolee derrickstolee mentioned this pull request Sep 17, 2020
Copy link
Member

@mjcheetham mjcheetham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! I would only echo what @jeffhostetler has already said.

On the src point, I best not comment since my view here is we shouldn't be doing this at all 😁
We shouldn't be forcing a practice on people - they should change to adopt the practice, or take the file scanning perf hit anyway. (whoops.. I commented)

@derrickstolee
Copy link
Contributor Author

On the src point, I best not comment since my view here is we shouldn't be doing this at all 😁
We shouldn't be forcing a practice on people - they should change to adopt the practice, or take the file scanning perf hit anyway. (whoops.. I commented)

You're right, we should allow people to opt-out with a --no-src option or something. However, for repos that do the right thing (the Scalar repo itself is an example) we should have happy path that makes it simple. Also, we can't break the existing default behavior for our current customers.

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update documentation

3 participants