Remove some leftover pain points from VFS for Git#381
Merged
derrickstolee merged 4 commits intomicrosoft:masterfrom May 28, 2020
Merged
Remove some leftover pain points from VFS for Git#381derrickstolee merged 4 commits intomicrosoft:masterfrom
derrickstolee merged 4 commits intomicrosoft:masterfrom
Conversation
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
jeffhostetler
approved these changes
May 28, 2020
Contributor
jeffhostetler
left a comment
There was a problem hiding this comment.
I'm not sure I'm understand the subtleties of the ProductUpgrader commit and GH vs NuGet changes, but everything else looks good.
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
fcd083a to
f3217b3
Compare
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
f3217b3 to
275fa89
Compare
Contributor
Author
I deleted the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scalar was created by forking the VFS for Git codebase, deleting a bunch of code, then renaming a bunch of files. It has since diverged significantly through many refactors.
One thing that has never worked is the
scalar upgradeverb when using GitHub as the source. The reason is that we package our releases differently than VFS for Git does, so the upgrader fails to find the Git installer and Scalar installer (instead, we have two.zipfiles, one for each platform). Since we are moving to another system for the typical upgrade pattern, we should just delete the GitHub upgrader. Thescalar upgradeverb will remain for the NuGet feed, when configured. This resolves #351.An issue was found in VFS for Git where the service would restart constantly when checking for an upgrade. The root cause was a problematic
Environment.Exit()call. See microsoft/VFSForGit#1668 for an equivalent change.Another annoying thing is the verbose output during
scalar clonethat repeats the given options. In the case of a non-GVFS protocol clone, some of these just don't make sense. Delete this output for clarity.Finally,
scalar clonefailed miserably when using a non-standard URL such asfile://. Fix that by doing some URL scanning in advance. If the URL does not start withhttp://orhttps://, we will not even try the GVFS protocol and will move on to a native Git clone. We also avoid any protocol prefix (X://) that is nothttp://,https://orssh://. For SSH, the protocol prefix is not required, so we do not require a protocol prefix. Resolves #378.Since this is a grab-bag of things, please review commit-by-commit. For the GitHub upgrader removal, consider ignoring whitespace changes.