Skip to content

scalar upgrade fails with "Could not find Git installer in the latest release" #351

@rainersigwald

Description

@rainersigwald
scalar upgrade --confirm
Checking for Scalar upgrades...Succeeded
New Scalar version 20.3.167.1 available in ring Fast.
Launching upgrade tool...

Installer launched in a new window. Do not run any git or scalar commands until the installer has completed.

from the other window

Downloading...Failed

ERROR: Could not find Git installer in the latest release.

Upgrade logs can be found at: C:\ProgramData\Scalar\Scalar.Upgrade\UpgraderLogs with file names that end with the installation ID: 20200310_110822.

Press Enter to exit.

from that log

[2020-03-10 11:09:25.5691 -05:00] TryRunPreUpgradeChecks (Start)
[2020-03-10 11:09:30.9643 -05:00] Information {"Message":"Successfully finished pre upgrade checks. Okay to run `scalar upgrade`."}
[2020-03-10 11:09:30.9663 -05:00] TryRunPreUpgradeChecks (Stop) {"DurationMs":5396}
[2020-03-10 11:09:30.9667 -05:00] TryCheckIfUpgradeAvailable (Start)
[2020-03-10 11:10:21.9613 -05:00] Information {"Message":"New release found - latest available version: 20.3.167.1"}
[2020-03-10 11:10:21.9614 -05:00] TryCheckIfUpgradeAvailable (Stop) {"DurationMs":50994}
[2020-03-10 11:10:22.0200 -05:00] Installed Version {"installedScalarVersion":"20.01.165.7","installedGitVersion":"2.25.0.vfs.1.1"}
[2020-03-10 11:10:22.0203 -05:00] TryDownloadUpgrade (Start) {"Upgrade Step":"TryDownloadUpgrade","Version":"20.3.167.1"}
[2020-03-10 11:15:51.8990 -05:00] Error {"Upgrade Step":"TryDownloadUpgrade","Version":"20.3.167.1","ErrorMessage":"TryDownloadNewestVersion failed. Could not find Git installer in the latest release."}
[2020-03-10 11:15:51.8991 -05:00] TryDownloadUpgrade (Stop) {"DurationMs":329878}

(that was under the debugger, the duration is bogus)

In the debugger, I can see:

this.newestRelease.Assets
Count = 2
    [0]: {Scalar.Common.GitHubUpgrader.Asset}
    [1]: {Scalar.Common.GitHubUpgrader.Asset}

this.newestRelease.Assets[0]
{Scalar.Common.GitHubUpgrader.Asset}
    DownloadURL: {https://github.com/microsoft/scalar/releases/download/v20.03.167.1/Installers_macOS_Release.tar.gz}
    LocalPath: null
    Name: "Installers_macOS_Release.tar.gz"
    Size: 120880351

this.newestRelease.Assets[1]
{Scalar.Common.GitHubUpgrader.Asset}
    DownloadURL: {System.Uri}
    LocalPath: null
    Name: "Installers_Windows_Release.zip"
    Size: 86376247

And indeed that seems to match the release assets. But isn't git packed into the .zip?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions