Mac install: use 'whoami' for user name#356
Merged
derrickstolee merged 1 commit intomicrosoft:masterfrom Mar 25, 2020
Merged
Conversation
kewillford
approved these changes
Mar 25, 2020
Member
kewillford
left a comment
There was a problem hiding this comment.
Looks good. Did you try running the install script with sudo and see if it returned root? Just curious.
Contributor
Author
I suppose that's a great reason for doing it the way we did. Also, going through the hoops of installing Maybe we should just close both here? |
Resolves microsoft#336. I am unable to reproduce the situation where 'logname' returns root while 'whoami' does not, but at least we have a fallback option. 'whoami' definitely returns root under 'sudo' so we do not want to start there. Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #336.
Since
sudo whoamialways returns "root", we should not just replace our use oflognamewithwhoami. Instead, fall back towhoamionly iflognamereturns "root".