Remove GVFS.Hooks projects by wilbaker · Pull Request #23 · microsoft/scalar

wilbaker · 2019-08-08T17:45:59Z

These projects are not required by GSD

The GVFS/GVFS.Common/Paths.cs file was split into two and Paths.Shared.cs was created in commit 2db0c03, in order to share methods such as Paths.GetGVFSEnlistmentRoot() with the GVFS.Hooks project. The original Paths.cs file was later renamed and moved to GVFS/GVFS.Platform.Windows/WindowsFileSystem.Shared.cs in commit 785ccb4. That file is now Scalar.Common/Platforms/Windows/WindowsFileSystem.Shared.cs, and its sole TryGetNormalizedPathImplementation() method is also implemented in the parallel POSIXFileSystem.Shared.cs file. Given that there is no longer a corresponding Scalar version of the GVFS.Hooks project, there is no need to split out certain (static) methods from the others in any of these classes. (The GVFS.Hooks project was removed in commit f12effc in PR microsoft#23.) Thus we rename Paths.Shared.cs back to just Paths.cs, and move the substance of the TryGetNormalizedPathImplementation() methods into the corresponding main per-platform classes for Windows and POSIX. This also allows us to convert these classes back from being partial ones split over two files each.

The POSIXPlatform.cs and POSIXPlatform.Shared.cs classes exist as a pair of partial classes in order to share the static methods in the latter with the GVFS.Hooks project; however, that project was removed in commit f12effc in PR microsoft#23, so we can merge the implementation of several methods back into the main POSIXPlatform class and remove the shared one.

The {Linux,Mac}Platform.cs and {Linux,Mac}Platform.Shared.cs classes exist as pairs of partial classes in order to share static methods in the Shared classes with the GVFS.Hooks project; however, that project was removed in commit f12effc in PR microsoft#23, so we can merge the implementation of several methods back into the common POSIXPlatform class and remove the shared ones. We also align all the per-platform EnvironmentVariables arrays to be private.

The WindowsPlatform.cs and WindowsPlatform.Shared.cs classes exist as a pair of partial classes in order to share the static methods in the latter with the GVFS.Hooks project; however, that project was removed in commit f12effc in PR microsoft#23, so we can merge the implementation of several methods back into the main WindowsPlatform class and remove the shared one. We also slightly reorder the GetUpgradeProtectedDataDirectory() method so it aligns with those in ScalarPlatform and POSIXPlatform, which may help with future refactoring or simplification.

The GVFS/GVFS.Common/GVFSEnlistment.cs file was split into two and GVFS/GVFS.Common/GVFSEnlistment.Shared.cs was created in commit ed04790, in order to share the IsUnattended() method with the GVFS.Hooks project. Given that there is no longer a corresponding Scalar version of the GVFS.Hooks project, there is no need to split out certain (static) methods from the others in any classes. (The GVFS.Hooks project was removed in commit f12effc in PR microsoft#23.) Thus we merge the IsUnattended() method into ScalarEnlistment.cs and remove the ScalarEnlistment.Shared.cs file.

The GVFS/GVFS.Common/ProductUpgraderInfo.cs file was split into two and GVFS/GVFS.Common/ProductUpgraderInfo.Shared.cs was created in commit d5d9e7d, in order to share the IsLocalUpgradeAvailable() method and some constant path strings with the GVFS.Hooks project. Given that there is no longer a corresponding Scalar version of the GVFS.Hooks project, there is no need to split out certain (static) methods from the others in any classes. (The GVFS.Hooks project was removed in commit f12effc in PR microsoft#23.) Thus we merge the IsLocalUpgradeAvailable() method, path constants, and several private methods into ProductUpgraderInfo.cs and remove the ProductUpgraderInfo.Shared.cs file.

The GVFS/GVFS.Common/NativeMethods.cs file was split into two and GVFS/GVFS.Common/NativeMethods.Shared.cs was created in commit 785ccb4, in order to share the ThrowLastWin32Exception() and GetFinalPathName() methods and some native Win32 enums and system call wrappers with the GVFS.Hooks project. Given that there is no longer a corresponding Scalar version of the GVFS.Hooks project, there is no need to split out certain (static) methods from the others in any classes. (The GVFS.Hooks project was removed in commit f12effc in PR microsoft#23.) Thus we merge the two methods, file attribute and access enums, and system call wrappers into NativeMethods.cs and remove the NativeMethods.Shared.cs file.