Updating release history related to PR #607#609
Merged
Conversation
|
|
||
| ## Unreleased | ||
|
|
||
| - RE2.Native will compile with the latest Windows SDK 10.0.* installed. [#607](https://github.com/microsoft/sarif-pattern-matcher/pull/607) |
Member
Member
|
Hello! What's happened here? We were going to pin our pipeline builds to a specific Win SDK and then document that version in our release notes. Is that still happening? :) |
Update release note to provide placeholder for actual windows sdk version used in release builds.
|
|
||
| ## Unreleased | ||
|
|
||
| - RE2.Native will now compile in all environments with the latest Windows SDK 10.0.* installed. [#607](https://github.com/microsoft/sarif-pattern-matcher/pull/607). Our current release pipelines build NuGet packages with Windows SDK version 10.0.22000. |
Member
There was a problem hiding this comment.
@eddynaka, we need to update this version w/what's actually used in our release/deployment pipeline build agents.
Collaborator
Author
There was a problem hiding this comment.
The version that you mentioned is the version that we will be using.
So, the text is accurate.
Thanks for updating it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This change will add an entry to the latest PR that got merged (#607).
When we release it, we will use the latest available in the windows-2022 VM:
https://github.com/actions/virtual-environments/blob/main/images/win/Windows2022-Readme.md#installed-windows-sdks