Skip to content

Implementing 'list' and 'listitem' accessibilityRoles#2743

Merged
2 commits merged into
microsoft:masterfrom
jonthysell:listacc
Jul 9, 2019
Merged

Implementing 'list' and 'listitem' accessibilityRoles#2743
2 commits merged into
microsoft:masterfrom
jonthysell:listacc

Conversation

@jonthysell

@jonthysell jonthysell commented Jul 8, 2019 •
edited by ghost
Loading

Copy link
Copy Markdown
Contributor
Microsoft Reviewers: Open in CodeFlow

@jthysell
Implementing list and listitem accessibilityRoles
139f676 
* Added 'list' and 'listitem' accessibilityRoles, #2578
* Added 'accessibilitySetSize' and 'accessibilityPosInSet' properties, #2579
* Cleaned up AutomationPeer tree, default View's Name to TextBlock contents, removed unnecessary empty peers

Added accessibilityLabel to Back button in RNTester
@jonthysell jonthysell requested a review from a team as a code owner July 8, 2019 23:05
@jonthysell jonthysell added vnext AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity) labels Jul 8, 2019
@ghost

ghost commented Jul 9, 2019

Copy link
Copy Markdown

Hello @jonthysell!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 60 minutes, a condition that will be fulfilled in about 3 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit af57045 into microsoft:master Jul 9, 2019
@harinikmsft harinikmsft mentioned this pull request Jul 17, 2019
Open
@jonthysell jonthysell deleted the listacc branch July 22, 2019 19:13
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ahimberg ahimberg ahimberg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonthysell @ahimberg @jthysell