[Telemetry] Enable data uploading#14039
Merged
danielayala94 merged 5 commits intomicrosoft:mainfrom Nov 7, 2024
Merged
Conversation
Contributor
Author
|
/azp run |
1 similar comment
Contributor
Author
|
/azp run |
Contributor
Author
|
Closing this PR for now. Once privacy review has cleared all telemetry aspects of RNW, I'll reopen this. |
Contributor
Author
|
Bring this PR back to life as we have the blessing of privacy folks. |
TatianaKapos
approved these changes
Nov 7, 2024
Contributor
There was a problem hiding this comment.
LGTM! I see you put "yes" on the changelog section, can you write what short blurb of what should go on the changelog for this PR? Example of last releases changelog: https://github.com/microsoft/react-native-windows/releases/tag/react-native-windows_v0.75.0
Also will this need to be in 0.76?
danielayala94
added a commit
to danielayala94/react-native-windows
that referenced
this pull request
Nov 7, 2024
* Set instrumentation key * Change files * Nit: Minor lint fix
TatianaKapos
added a commit
that referenced
this pull request
Nov 11, 2024
* [Telemetry] Migration from AppInsights to 1DS (#13493) * Draft of telemetry refactoring * Better draft, including most (if not all?) properties * Various fixes, it now compiles * Refactor, and temporary commenting tests * All tests passing! But will need to clean up a few things * Polished some code, re-enabled some errorUtils tests * Change files * Update yarn.lock * Let yarn lint:fix cook * Simplifying * Nit: ordering * Avoid unnecessary JSON work * nit * Mostly placing some common props into Part A ext, plus adding/removing props * Distinguish between deviceClass and nodePlatform * Nit * [Telemetry] Enable data uploading (#14039) * Set instrumentation key * Change files * Nit: Minor lint fix * Change files * update yarn * yarn again * lint:fix --------- Co-authored-by: Tatiana Kapos <tatianakapos@microsoft.com>
danielayala94
added a commit
to danielayala94/react-native-windows
that referenced
this pull request
Jan 28, 2025
* Set instrumentation key * Change files * Nit: Minor lint fix
danielayala94
added a commit
that referenced
this pull request
Jan 29, 2025
* [Telemetry] Migration from AppInsights to 1DS (#13493) * Draft of telemetry refactoring * Better draft, including most (if not all?) properties * Various fixes, it now compiles * Refactor, and temporary commenting tests * All tests passing! But will need to clean up a few things * Polished some code, re-enabled some errorUtils tests * Change files * Update yarn.lock * Let yarn lint:fix cook * Simplifying * Nit: ordering * Avoid unnecessary JSON work * nit * Mostly placing some common props into Part A ext, plus adding/removing props * Distinguish between deviceClass and nodePlatform * Nit * [Telemetry] Enable data uploading (#14039) * Set instrumentation key * Change files * Nit: Minor lint fix * [Telemetry] Expand field sanitization to codedError.data (#14161) * Scrub PII from codedError, add unit test * Nit: comment updates * Lint fixes * Change files * Enhanced bug fix using recursion, added test field cases * Lint fix * Sanitize any, and test fixes * Lint fix, again * [Telemetry] Bug fix in `codedError.data` from `trackException()` (#14191) * Bug fix * Simplify fix, add unit test * Change files * Nit: change test description * Manual change to add UseFabric (RnwNewArch not in 0.75) * [Telemetry] Address package name limitations - Take 2 (#14259) * Introducing package name processing * Add trimming if string length > 100 * Change files * Change files * Update yarn.lock * Lint fixes * Add RnwNewArch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Set the telemetry instrumentation key to upload telemetry.
Resolves #14089
Type of Change
Why
Currently, the telemetry data goes nowhere.
As the backend is taking shape, we can start to let the data to flow upstream.
What
Instead of an empty instrumentation key, set the one associated to the RNW telemetry project.
Screenshots
N/A
Testing
Ran the telemetry unit tests. Number of telemetry instances is correctly updated to the backend, with little to no delay. Measures are getting updated too with the new data.
Changelog
Yes
Enables telemetry collection to monitor RNW reliability, performance, and usage.
Microsoft Reviewers: Open in CodeFlow