Undo a rearchitecture that breaks us downstream#777
Merged
HeyImChris merged 35 commits intomicrosoft:0.63-stablefrom Jun 1, 2021
Merged
Undo a rearchitecture that breaks us downstream#777HeyImChris merged 35 commits intomicrosoft:0.63-stablefrom
HeyImChris merged 35 commits intomicrosoft:0.63-stablefrom
Conversation
* Update RCTCxxBridge.mm * add nullability checks
…ndle (facebook#27844)" This reverts commit 6f627f6.
|
…ndle (facebook#27844)" This reverts commit 6f627f6.
…ative-macos into 63_initRearch
…ative-macos into 63_initRearch
Saadnajmi
approved these changes
Jun 1, 2021
Saadnajmi
added a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Jun 11, 2021
This reverts commit 73224cf.
harrieshin
pushed a commit
that referenced
this pull request
Jun 12, 2021
This reverts commit 73224cf, which itself was a revert of a commit. So we're bringing back the original change. We thought it would break things downstream for us, but are electing to instead fix things downstream rather than undo this commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
This change I'm reverting for the 63 stable branch is an improvement in that we only do the global JS variable init once, but it has the downside that it splits out the JS runtime init from the bundle loading which breaks a scenario we rely on downstream.
I'm still investigating how to rearchitect our downstream client code to be compatible with this change which is why I'm just making this revert in 0.63 instead of master. In the short term, we need to unblock ourselves and anyone else that isn't set up to properly handle this new scenario of rearchitecting the SDX setup.
I also hit some failures using Flipper. We need a different version than is compatible so for now I disabled Flipper as we don't need it on.
git revert 6f627f684bb6506a677c9632b2710e4a541690a9Changelog
[General] [Minor] - git revert a 63 initialization rearchitecture
Test Plan
This is going back to what is in 0.62 so it should all still work as well as 0.62 did. I ran the test app and basic scenarios seem to still work as expected.