Skip to content

Change key identifier from "Esc" -> "Escape"#720

Merged
HeyImChris merged 1 commit intomicrosoft:masterfrom
appden:fix-esc-key
Feb 11, 2021
Merged

Change key identifier from "Esc" -> "Escape"#720
HeyImChris merged 1 commit intomicrosoft:masterfrom
appden:fix-esc-key

Conversation

@appden
Copy link
Copy Markdown

@appden appden commented Feb 10, 2021 •
edited by ghost
Loading

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

This aligns the name to be same as in react-native-windows and the standard.

Changelog

[macOS] [Fixed] - Change key identifier from "Esc" -> "Escape"

Test Plan

Confirmed correct key identifier is logged in the Key Event example in RNTester.

Microsoft Reviewers: Open in CodeFlow

@appden appden requested a review from alloy as a code owner February 10, 2021 23:23
@appden appden requested a review from HeyImChris February 10, 2021 23:23
@harrieshin
Copy link
Copy Markdown

harrieshin commented Feb 11, 2021

lets make sure we cherry pick to .63 stable as well!

@HeyImChris HeyImChris merged commit df4e7da into microsoft:master Feb 11, 2021
@HeyImChris
Copy link
Copy Markdown

HeyImChris commented Feb 11, 2021

lets make sure we cherry pick to .63 stable as well!

@appden are you able to make this change in the 0.63-stable branch as well? If not I can, just let me know

@appden
Copy link
Copy Markdown
Author

appden commented Feb 11, 2021

@appden are you able to make this change in the 0.63-stable branch as well? If not I can, just let me know

Just clarifying: are you asking that I open another PR targeting that branch?

HeyImChris pushed a commit to HeyImChris/react-native-macos that referenced this pull request Feb 11, 2021
@appden @HeyImChris
Change key identifier from "Esc" -> "Escape" (microsoft#720)
e4fcc19
@HeyImChris
Copy link
Copy Markdown

HeyImChris commented Feb 11, 2021

@appden are you able to make this change in the 0.63-stable branch as well? If not I can, just let me know

Just clarifying: are you asking that I open another PR targeting that branch?

Hey not a problem, here's what I meant 0.63-stable PR

HeyImChris added a commit that referenced this pull request Feb 17, 2021
@HeyImChris @appden
git cherry-pick escape fix to 0.63-stable branch (#722)
b9ce92f 
* Add nullability checks (#704)

* Update RCTCxxBridge.mm

* add nullability checks

* Change key identifier from "Esc" -> "Escape" (#720)

Co-authored-by: Scott Kyle <scott@appden.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alloy alloy Awaiting requested review from alloy

1 more reviewer

@HeyImChris HeyImChris HeyImChris approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Partner: Facebook

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@appden @harrieshin @HeyImChris