Skip to content

Use $buildNumber$ token for NuGet #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
statm merged 3 commits into from
Dec 5, 2019
Merged

Use $buildNumber$ token for NuGet #198

statm merged 3 commits into from
Dec 5, 2019

Conversation

@statm
Copy link

@statm statm commented Dec 4, 2019 •
edited by ghost
Loading

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

(TSIA) Use proper token, $buildNumber$, in ReactAndroid.nuspec and ReactApple.nuspec.

Microsoft Reviewers: Open in CodeFlow

@statm statm requested a review from acoates-ms as a code owner December 4, 2019 20:07
@pull-bot
Copy link

pull-bot commented Dec 4, 2019 •
edited
Loading

Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.
📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against a46ede6

@statm statm closed this Dec 5, 2019
@statm statm reopened this Dec 5, 2019
@statm statm merged commit 39ce8a7 into microsoft:master Dec 5, 2019
christophpurrer pushed a commit to christophpurrer/react-native-macos that referenced this pull request Aug 14, 2025
@vzaidman @facebook-github-bot
Update debugger-frontend from 9215667...e87564a (facebook#53256)
856f52a 
Summary:
Pull Request resolved: facebook#53256

Changelog: [Internal] - Update `react-native/debugger-frontend` from 9215667...e87564a

Resyncs `react-native/debugger-frontend` from GitHub - see `rn-chrome-devtools-frontend` [changelog](facebook/react-native-devtools-frontend@9215667...e87564a).

### Changelog

| Commit | Author | Date/Time | Subject |
| ------ | ------ | --------- | ------- |
| [e87564a24](facebook/react-native-devtools-frontend@e87564a24) | Vitali Zaidman (vzaidman@gmail.com) | 2025-08-06T12:11:08+01:00 | [prevent stack trace entries in console UI from being inline so a new line is always added between them and other printed elements (microsoft#198)](facebook/react-native-devtools-frontend@e87564a24) |

Reviewed By: robhogan

Differential Revision: D80181542

fbshipit-source-id: 517425504251441703b9b96fdeb6956f4db7d53b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@acoates-ms acoates-ms acoates-ms approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@statm @pull-bot @acoates-ms