Project rename: Proxy -> Proxy 4 #302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 1, 2025
mingxwa
requested changes
Jun 2, 2025
mingxwa
requested changes
Jun 3, 2025
mingxwa
reviewed
Jun 4, 2025
mingxwa
reviewed
Jun 4, 2025
mingxwa
reviewed
Jun 4, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR renames the Proxy library to Proxy 4, updating the CMake project, target names, module imports, and documentation accordingly. Key changes include updating C++ module import statements (from proxy to proxy.v4), revising CMake configuration files to use the new target and namespace (msft_proxy::proxy4), and updating documentation and README references.
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/cpp20_modules/main.cpp | Changed module import from “proxy” to “proxy.v4”. |
| tests/cpp20_modules/foo.cpp | Updated module import to “proxy.v4”. |
| tests/cpp20_modules/CMakeLists.txt | Revised target linking to use msft_proxy::proxy4_module. |
| include/proxy/v4/*.h, *.ixx | Introduced new header and module interface files under the “v4” namespace. |
| cmake/* | Removed outdated Proxy target scripts and introduced new Proxy4 target/configuration files. |
| docs/* and README.md | Updated documentation and examples to refer to proxy4. |
| CMakeLists.txt | Renamed the project and updated target names/export configurations accordingly. |
tian-lt
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecates PR #301. Resolves issue #300.
This does the following changes:
pro::v4::instead ofpro::.Note: This does NOT make it possible for Proxy 3 and Proxy 4 to work within the same project. The reason is due to the use of
inline namespace v4in Proxy 4 while Proxy 3 declares everything underpro::namespace. When both versions are included, the errorreference to 'XXX' is ambiguouswill be emitted.I've locally tested to confirm that removing the
inlinefrominline namespacemakes it possible for both Proxy 3 and Proxy 4 to compile within the same TU (which also confirms that all implementations now correctly reference thepro::v4namsepace, unlike #301 which won't compile wheninlineis removed frominline namespace).This will also make sure that a future Proxy 5 will work with Proxy 4 together, as long as the user explicitly requests the
pro::v4::/pro::v5::namespace.This PR does not include the necessary tests to verify running Proxy 3 (
3.3.0tag) and Proxy 4 at the same time. However, that can be added in a separate PR if it's desired. Doing so will require introducing a new feature gate macro that controls the use ofinlineofinline namespace.Please, look at the individual commits, instead of the 20 changed files as a whole. I've made sure that each commit correctly tracks the incremental changes. It happens that GitHub doesn't correctly track the changes and thinks that I wrote the entire
proxy/v4/proxy.hmyself.