Add an inline namespace for versioning #301
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| #include <proxy/proxy.h> | ||
|
|
||
| export module proxy; |
Contributor
There was a problem hiding this comment.
Suggest renaming the module name to proxy.v4;. This unblocks a future use case where both the module proxy.v4 and proxy.v5 can be built within the same project (assuming the user manually acquired the older Proxy 4, e.g. with git submodule, while an upstream library acquires Proxy 5 on its own).
The consumer would be using import proxy.v4; instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional changes. Resolves #300