fix(test): load require-reached files as commonjs in sync ESM loader#41399
Merged
Conversation
The synchronous ESM loader loaded `type: module` files reached via `require` as real ESM. Their bare/subpath specifiers then fell through to Node's native ESM resolver, which never tries the `.ts` extension, so extensionless TypeScript subpath imports across workspace symlinks failed. Load files reached under the `require` condition as CommonJS instead, matching the asynchronous loader, so TypeScript extension substitution applies to their child specifiers. Fixes: microsoft#41371
Contributor
Test results for "MCP"1 failed 7353 passed, 1122 skipped Merge workflow run. |
Contributor
Test results for "tests 1"1 failed 5 flaky48912 passed, 1142 skipped Merge workflow run. |
pavelfeldman
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
type: modulefiles reached viarequireas real ESM, so their bare/subpath specifiers fell through to Node's native ESM resolver, which never tries the.tsextension. This broke extensionless TypeScript subpath imports across workspace (pnpm) symlinks — a regression from the async loader.requirecondition as CommonJS (read fromcontext.conditionsin theloadhook), matching the async loader, so TypeScript extension substitution applies to their child specifiers.Fixes #41371