fix(har): WebSocket message timestamps should be in milliseconds#41364
Merged
Conversation
yury-s
reviewed
Jun 18, 2026
| this._timestampBaselineForWebSocket.set(event.requestId, wallTimeMs - event.timestamp); | ||
| this._page!.frameManager.onWebSocketRequest(event.requestId, headersObjectToArray(event.request.headers, '\n'), wallTimeMs); | ||
| this._timestampBaselineForWebSocket.set(event.requestId, event.wallTime - event.timestamp); | ||
| this._page!.frameManager.onWebSocketRequest(event.requestId, headersObjectToArray(event.request.headers, '\n'), event.wallTime); |
Member
There was a problem hiding this comment.
FrameManager.onWebSocketRequest receives wallTimeMs, but event.wallTime is time since epoch in seconds in chromium. Shouldn't the units match?
Contributor
Author
There was a problem hiding this comment.
oh shoot good catch! yes i make sure this is not affected by the fix
fc7a0bd to
3b2fd77
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
yury-s
approved these changes
Jun 18, 2026
| _onWebSocketWillSendHandshakeRequest(event: Protocol.Network.webSocketWillSendHandshakeRequestPayload) { | ||
| const wallTimeMs = event.walltime * 1000; | ||
| this._timestampBaselineForWebSocket.set(event.requestId, wallTimeMs - event.timestamp); | ||
| this._timestampBaselineForWebSocket.set(event.requestId, wallTimeMs - (event.timestamp * 1000)); |
Member
There was a problem hiding this comment.
nit drop braces
Suggested change
| this._timestampBaselineForWebSocket.set(event.requestId, wallTimeMs - (event.timestamp * 1000)); | |
| this._timestampBaselineForWebSocket.set(event.requestId, wallTimeMs - event.timestamp * 1000); |
Contributor
Author
There was a problem hiding this comment.
i personally like the extra clarity just in case, but if this is our style then i can follow :)
the `timestamp` should also be multipled by 1000 just like the `walltime`
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Test results for "MCP"7354 passed, 1122 skipped Merge workflow run. |
Contributor
Test results for "tests 1"Warning The triggering workflow run ended with status 5 flaky35083 passed, 583 skipped Merge workflow run. |
dgozman
pushed a commit
that referenced
this pull request
Jun 19, 2026
…be in milliseconds the `timestamp` should also be multipled by 1000 just like the `walltime` fixes <#41360>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the
timestampshould also be multipled by 1000 just like thewalltimefixes #41360