feat: per-assertion snapshot path template in config#34537
Merged
dgozman merged 1 commit intomicrosoft:mainfrom Jan 29, 2025
Merged
feat: per-assertion snapshot path template in config#34537dgozman merged 1 commit intomicrosoft:mainfrom
dgozman merged 1 commit intomicrosoft:mainfrom
Conversation
Introduces the following properties in the config that take
precedence over `config.snapshotPathTemplate`.
```ts
export default {
expect: {
toHaveScreenshot: {
pathTemplate: '__screenshots__{/projectName}/{testFilePath}/{arg}{ext}',
},
toMatchAriaSnapshot: {
pathTemplate: '__snapshots__/{testFilePath}/{arg}{ext}',
},
},
};
```
Additionally, changes the default template for aria snapshots to:
```
{snapshotDir}/{testFileDir}/{testFileName}-snapshots/{arg}{ext}
```
This is technically a breaking change.
Contributor
Test results for "tests 1"14 flaky37749 passed, 660 skipped Merge workflow run. |
pavelfeldman
approved these changes
Jan 29, 2025
dgozman
added a commit
to dgozman/playwright
that referenced
this pull request
Jan 30, 2025
dgozman
added a commit
that referenced
this pull request
Jan 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces the following properties in the config that take precedence over
config.snapshotPathTemplate.Additionally, changes the default template for aria snapshots to:
This is technically a breaking change.
Fixes #34483.