Skip to content

fix(firefox): disable fetch keep-alive for now before a proper fix#34530

Merged
dgozman merged 1 commit intomicrosoft:mainfrom
aslushnikov:fix-keepalive
Jan 29, 2025
Merged

fix(firefox): disable fetch keep-alive for now before a proper fix#34530
dgozman merged 1 commit intomicrosoft:mainfrom
aslushnikov:fix-keepalive

Conversation

@aslushnikov
Copy link
Copy Markdown
Contributor

Fixes #34497

@github-actions
Copy link
Copy Markdown
Contributor

Test results for "tests 1"

1 failed
❌ [webkit-library] › tests/library/video.spec.ts:441:5 › screencast › should work for popups @webkit-ubuntu-22.04-node18

12 flaky ⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › tests/ui-mode-test-setup.spec.ts:98:5 › should show errors in config @macos-latest-node18-1
⚠️ [chromium-library] › tests/library/video.spec.ts:379:5 › screencast › should capture navigation @ubuntu-20.04-chromium-tip-of-tree
⚠️ [playwright-test] › tests/ui-mode-trace.spec.ts:341:5 › should work behind reverse proxy @ubuntu-latest-node18-1
⚠️ [playwright-test] › tests/ui-mode-trace.spec.ts:341:5 › should work behind reverse proxy @ubuntu-latest-node20-1
⚠️ [webkit-library] › tests/library/browsertype-connect.spec.ts:554:5 › launchServer › should error when saving download after deletion @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/popup.spec.ts💯3 › should inherit touch support from browser context @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/popup.spec.ts:115:3 › should inherit viewport size from browser context @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/popup.spec.ts:129:3 › should use viewport size from window features @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:107:5 › fill should not leak @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:161:5 › waitFor should not leak @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-set-input-files.spec.ts:205:3 › should upload multiple large files @webkit-ubuntu-22.04-node18

37735 passed, 660 skipped
✔️✔️✔️

Merge workflow run.

@dgozman dgozman merged commit b419527 into microsoft:main Jan 29, 2025
28 of 29 checks passed
dgozman pushed a commit to dgozman/playwright that referenced this pull request Jan 29, 2025
dgozman added a commit that referenced this pull request Jan 29, 2025
…efore a proper fix (#34534)

Co-authored-by: Andrey Lushnikov <aslushnikov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Firefox not handling keepalive: true fetch requests

2 participants