fix: follow the pseudo attr value in firefox computed style#34525
Merged
pavelfeldman merged 1 commit intomicrosoft:mainfrom Jan 28, 2025
Merged
fix: follow the pseudo attr value in firefox computed style#34525pavelfeldman merged 1 commit intomicrosoft:mainfrom
pavelfeldman merged 1 commit intomicrosoft:mainfrom
Conversation
dgozman
approved these changes
Jan 28, 2025
| // Firefox does not resolve attribute accessors in content. | ||
| const attrName = content.substring('attr('.length, content.length - 1).trim(); | ||
| const attrValue = element.getAttribute(attrName); | ||
| return ' ' + (attrValue || '') + ' '; |
Collaborator
There was a problem hiding this comment.
I think this should take display into account, similar to line 374.
74c0b90 to
114631d
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
Test results for "tests 1"2 failed 11 flaky37728 passed, 661 skipped Merge workflow run. |
pavelfeldman
added a commit
that referenced
this pull request
Jan 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34507