Skip to content

fix: allow changed to be passed in config#34473

Merged
pavelfeldman merged 1 commit intomicrosoft:mainfrom
pavelfeldman:update-snapshots-changed
Jan 24, 2025
Merged

fix: allow changed to be passed in config#34473
pavelfeldman merged 1 commit intomicrosoft:mainfrom
pavelfeldman:update-snapshots-changed

Conversation

@pavelfeldman
Copy link
Copy Markdown
Member

@pavelfeldman pavelfeldman commented Jan 24, 2025 •
edited
Loading

Fixes #34462

@pavelfeldman pavelfeldman force-pushed the update-snapshots-changed branch from 716684f to 78b3361 Compare January 24, 2025 21:29
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@pavelfeldman pavelfeldman force-pushed the update-snapshots-changed branch from 78b3361 to f7c9f22 Compare January 24, 2025 22:27
@pavelfeldman pavelfeldman force-pushed the update-snapshots-changed branch from f7c9f22 to 6d40ad9 Compare January 24, 2025 23:09
@github-actions

This comment has been minimized.

Sign in to view
@pavelfeldman pavelfeldman merged commit 245f4b5 into microsoft:main Jan 24, 2025
pavelfeldman added a commit that referenced this pull request Jan 24, 2025
@pavelfeldman
cherry-pick(#34473): fix: allow changed to be passed in config
2c85ade
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 24, 2025

Test results for "tests 1"

1 failed
❌ [webkit-page] › tests/page/page-leaks.spec.ts:107:5 › fill should not leak @webkit-ubuntu-22.04-node18

14 flaky ⚠️ [chromium-page] › tests/page/page-event-popup.spec.ts:149:3 › should not treat navigations as new popups @chromium-ubuntu-22.04-node22
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsercontext-clearcookies.spec.ts:116:3 › should remove cookies by path @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsercontext-device.spec.ts:45:5 › device › should scroll to click @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsercontext-viewport-mobile.spec.ts:157:5 › mobile viewport › mouse should work with mobile viewports and cross process navigations @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsercontext-viewport-mobile.spec.ts:206:5 › mobile viewport › view scale should reset after navigation @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/popup.spec.ts:129:3 › should use viewport size from window features @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/screenshot.spec.ts:44:14 › page screenshot › should work with a mobile viewport @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/video.spec.ts:441:5 › screencast › should work for popups @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:82:5 › click should not leak @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:161:5 › waitFor should not leak @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-set-input-files.spec.ts:205:3 › should upload multiple large files @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › tests/ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

37695 passed, 648 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yury-s yury-s yury-s approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: updateSnapshots "changed" throws an error

2 participants

@pavelfeldman @yury-s