fix(trace): in indexTree check isVisible before adding to result#33797
Merged
Skn0tt merged 5 commits intomicrosoft:mainfrom Nov 28, 2024
Merged
fix(trace): in indexTree check isVisible before adding to result#33797Skn0tt merged 5 commits intomicrosoft:mainfrom
indexTree check isVisible before adding to result#33797Skn0tt merged 5 commits intomicrosoft:mainfrom
Conversation
dgozman
approved these changes
Nov 28, 2024
Contributor
Test results for "tests 1"1 failed 1 flaky37189 passed, 650 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #33788.
2e8e7a6 rewrote how the tree is composed. The bug is that it appends onto
resultwithout checking if the node is visible.