Skip to content

fix(trace-viewer): fix ui issue on network request details#32553

Merged
mxschmitt merged 2 commits intomicrosoft:mainfrom
morenyang:fix-ui-issue-network-request-details
Sep 12, 2024
Merged

fix(trace-viewer): fix ui issue on network request details#32553
mxschmitt merged 2 commits intomicrosoft:mainfrom
morenyang:fix-ui-issue-network-request-details

Conversation

@morenyang
Copy link
Copy Markdown
Contributor

Fixes #32552

fixes can not show full body in network request details when response have multiple line, and fixes the scrollbar display issue in request details.

Fixes microsoft#32552
@github-actions

This comment has been minimized.

user-select: text;
line-height: 24px;
margin-left: 10px;
padding-left: 10px;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
padding-left: 10px;
margin-left: 10px;

Copy link
Copy Markdown
Contributor

@mxschmitt mxschmitt Sep 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted this for now. While it seems like an issue (double spacing) its unrelated to the actual issue we are fixing here. Happy to see a follow-up there.

Signed-off-by: Max Schmitt <max@schmitt.mx>
@mxschmitt mxschmitt merged commit 6a0009f into microsoft:main Sep 12, 2024
mxschmitt added a commit that referenced this pull request Sep 12, 2024
@github-actions
Copy link
Copy Markdown
Contributor

Test results for "tests 1"

2 failed
❌ [installation tests] › playwright-electron-should-work.spec.ts:44:5 › should work when wrapped inside @playwright/test and trace is enabled
❌ [playwright-test] › babel.spec.ts:135:5 › should not transform external

1 flaky ⚠️ [chromium-library] › library/page-clock.spec.ts:343:3 › popup › should not run time before popup on pause

31611 passed, 584 skipped
✔️✔️✔️

Merge workflow run.

whazor pushed a commit to whazor/playwright-trace-viewer-plus that referenced this pull request Jan 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: broken UI while showing network response body

2 participants