Skip to content

feat(chromium-tip-of-tree): roll to r1240#31650

Closed
playwrightmachine wants to merge 1 commit intomainfrom
roll-into-pw-chromium-tip-of-tree/1240
Closed

feat(chromium-tip-of-tree): roll to r1240#31650
playwrightmachine wants to merge 1 commit intomainfrom
roll-into-pw-chromium-tip-of-tree/1240

Conversation

@playwrightmachine
Copy link
Copy Markdown
Contributor

@playwrightmachine playwrightmachine commented Jul 11, 2024 •
edited by mxschmitt
Loading

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 11, 2024

Test results for "tests 1"

2 failed
❌ [chromium-page] › page/interception.spec.ts:125:3 › should intercept network activity from worker 2
❌ [chromium-page] › page/workers.spec.ts:228:3 › should support extra http headers

7 flaky ⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [playwright-test] › ui-mode-test-progress.spec.ts:165:5 › should update tracing network live
⚠️ [webkit-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture

28826 passed, 708 skipped
✔️✔️✔️

Merge workflow run.

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@mxschmitt mxschmitt added CQ1 and removed CQ1 labels Jul 11, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 11, 2024

Test results for "tests others"

1 failed
❌ [playwright-test] › reporter-html.spec.ts:390:5 › created › should use different path if attachments base url option is provided

4 flaky ⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:223:5 › should queue watches
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [playwright-test] › ui-mode-test-screencast.spec.ts:21:5 › should show screenshots

17796 passed, 484 skipped
✔️✔️✔️

Merge workflow run.

@mxschmitt
Copy link
Copy Markdown
Contributor

mxschmitt commented Jul 11, 2024

Bisect: npx bisect-chrome --good 1324454 --bad 1325713 --shell "npm run ctest -- --reporter=list page/interception.spec.ts:125:3"

Tests:

  • page/interception.spec.ts:125:3 › should intercept network activity from worker 2
  • page/workers.spec.ts:228:3 › should support extra http headers

Results:

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 11, 2024

Test results for "tests 2"

2 fatal errors, not part of any test
15 failed
❌ [chromium-page] › page/interception.spec.ts:125:3 › should intercept network activity from worker 2
❌ [chromium-page] › page/workers.spec.ts:228:3 › should support extra http headers
❌ [chromium-page] › page/interception.spec.ts:125:3 › should intercept network activity from worker 2
❌ [chromium-page] › page/workers.spec.ts:228:3 › should support extra http headers
❌ [chromium-page] › page/interception.spec.ts:125:3 › should intercept network activity from worker 2
❌ [chromium-page] › page/workers.spec.ts:228:3 › should support extra http headers
❌ [chromium-page] › page/interception.spec.ts:125:3 › should intercept network activity from worker 2
❌ [chromium-page] › page/workers.spec.ts:228:3 › should support extra http headers
❌ [chromium-page] › page/interception.spec.ts:125:3 › should intercept network activity from worker 2
❌ [chromium-page] › page/workers.spec.ts:228:3 › should support extra http headers
❌ [chromium-library] › library/signals.spec.ts:45:5 › should remove temp dir on process.exit
❌ [chromium-page] › page/interception.spec.ts:125:3 › should intercept network activity from worker 2
❌ [chromium-page] › page/workers.spec.ts:228:3 › should support extra http headers
❌ [firefox-library] › library/signals.spec.ts:45:5 › should remove temp dir on process.exit
❌ [webkit-library] › library/signals.spec.ts:45:5 › should remove temp dir on process.exit

92 flaky ⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:30:3 › context request should pick up proxy credentials
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-viewport.spec.ts:145:12 › should drag with high dpi
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:586:7 › cli codegen › should select with size attribute
⚠️ [chromium-page] › page/page-mouse.spec.ts:166:3 › should trigger hover state
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-viewport.spec.ts:145:12 › should drag with high dpi
⚠️ [chromium-page] › page/page-add-locator-handler.spec.ts:90:5 › should work with locator.hover()
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/trace-viewer.spec.ts:745:1 › should follow redirects
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/capabilities.spec.ts:137:3 › should not crash on showDirectoryPicker
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:23:7 › cli codegen › should click
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [firefox-page] › page/page-mouse.spec.ts:147:3 › should select the text with mouse
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [firefox-page] › page/locator-misc-1.spec.ts:21:3 › should hover @smoke
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [firefox-page] › page/elementhandle-misc.spec.ts:27:3 › should hover when Node is removed
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [firefox-library] › library/browsercontext-strict.spec.ts:38:5 › strict context mode › should fail page.click in strict mode
⚠️ [firefox-library] › library/browsertype-connect.spec.ts:196:5 › launchServer › should be able to connect two browsers at the same time
⚠️ [firefox-library] › library/selector-generator.spec.ts:567:5 › selector generator › should generate multiple: noText in text
⚠️ [firefox-library] › library/tracing.spec.ts:292:5 › should overwrite existing file
⚠️ [firefox-page] › page/elementhandle-misc.spec.ts:20:3 › should hover
⚠️ [firefox-page] › page/page-click-timeout-4.spec.ts:20:3 › should timeout waiting for stable position
⚠️ [firefox-page] › page/page-click.spec.ts:97:3 › should click the 1x1 div
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-page] › page/page-add-locator-handler.spec.ts:90:5 › should work with locator.hover()
⚠️ [chromium-page] › page/page-mouse.spec.ts:221:3 › should tween mouse movement
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/capabilities.spec.ts:137:3 › should not crash on showDirectoryPicker
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/signals.spec.ts:62:7 › signals › should report browser close signal 2
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [firefox-library] › library/signals.spec.ts:62:7 › signals › should report browser close signal 2
⚠️ [firefox-page] › page/frame-goto.spec.ts:46:3 › should continue after client redirect
⚠️ [webkit-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [webkit-library] › library/video.spec.ts:651:5 › screencast › should throw if browser dies
⚠️ [webkit-page] › page/page-goto.spec.ts:277:3 › should fail when navigating to bad SSL after redirects
⚠️ [webkit-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:431:7 › cli codegen › should update hover model on action
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:531:7 › cli codegen › should consume pointer events
⚠️ [webkit-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [webkit-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:426:7 › cli codegen › should emit single keyup on ArrowDown
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:483:7 › cli codegen › should check a radio button
⚠️ [webkit-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [webkit-library] › library/browsercontext-viewport.spec.ts:145:12 › should drag with high dpi
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:292:7 › cli codegen › should fill textarea
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:521:7 › cli codegen › should uncheck
⚠️ [webkit-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [webkit-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [webkit-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [webkit-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture

203051 passed, 9082 skipped, 1362 did not run
✔️✔️✔️

Merge workflow run.

@mxschmitt mxschmitt marked this pull request as draft July 12, 2024 14:00
@mxschmitt mxschmitt mentioned this pull request Jul 18, 2024
Merged
mxschmitt pushed a commit that referenced this pull request Jul 18, 2024
@dgozman
feat(chromium-tip-of-tree): roll to r1241 (#31748)
e78ce85 
Closes #31650
Closes #31705
Relates #31747
@mxschmitt mxschmitt deleted the roll-into-pw-chromium-tip-of-tree/1240 branch July 27, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CQ1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@playwrightmachine @mxschmitt