Skip to content

Revert "feat(evaluate): serialize map and set (#26730)"#27219

Merged
dgozman merged 1 commit intomicrosoft:mainfrom
dgozman:revert-ee203b7
Sep 21, 2023
Merged

Revert "feat(evaluate): serialize map and set (#26730)"#27219
dgozman merged 1 commit intomicrosoft:mainfrom
dgozman:revert-ee203b7

Conversation

@dgozman
Copy link
Contributor

@dgozman dgozman commented Sep 20, 2023

This reverts commit ee203b7.

References #24040.
Fixes #27181.

@github-actions
Copy link
Contributor

Test results for "tests 1"

8 flaky ⚠️ [chromium] › page/page-event-request.spec.ts:101:3 › should report navigation requests and responses handled by service worker
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-event-request.spec.ts:130:3 › should report navigation requests and responses handled by service worker with routing
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [webkit] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker
⚠️ [webkit] › library/inspector/cli-codegen-javascript.spec.ts:87:5 › should save the codegen output to a file if specified
⚠️ [playwright-test] › ui-mode-test-progress.spec.ts:167:5 › should update tracing network live

25664 passed, 605 skipped
✔️✔️✔️

Merge workflow run.

@dgozman dgozman merged commit b9509b3 into microsoft:main Sep 21, 2023
dgozman added a commit to dgozman/playwright that referenced this pull request Sep 21, 2023
dgozman added a commit that referenced this pull request Sep 21, 2023
Germandrummer92 pushed a commit to OctoMind-dev/playwright that referenced this pull request Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] evaluate serializing fails at 1.38

2 participants