Skip to content

fix: custom expect matchers on Locator/Page/APIResponse instance#27117

Merged
mxschmitt merged 1 commit intomicrosoft:mainfrom
mxschmitt:custom-expect-matcher-type
Sep 15, 2023
Merged

fix: custom expect matchers on Locator/Page/APIResponse instance#27117
mxschmitt merged 1 commit intomicrosoft:mainfrom
mxschmitt:custom-expect-matcher-type

Conversation

@mxschmitt
Copy link
Contributor

Fixes #27113

@github-actions
Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [installation tests] › playwright-cli-codegen.spec.ts:18:5 › codegen should work

7 flaky ⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/browsertype-connect.spec.ts:648:5 › launchServer › should upload large file
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-event-request.spec.ts:101:3 › should report navigation requests and responses handled by service worker
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [playwright-test] › ui-mode-test-progress.spec.ts:167:5 › should update tracing network live
⚠️ [webkit] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker

25615 passed, 605 skipped
✔️✔️✔️

Merge workflow run.

@mxschmitt mxschmitt merged commit 0d44405 into microsoft:main Sep 15, 2023
github-actions bot added a commit that referenced this pull request Sep 15, 2023
mxschmitt pushed a commit that referenced this pull request Sep 15, 2023
…esponse instance (#27125)

This PR cherry-picks the following commits:

- 0d44405

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[REGRESSION]: No longer able to extend PlaywrightTest.Matchers type for locators and pages

2 participants