Skip to content

fix(resolver): allow importing packages with non-index main script#26692

Merged
dgozman merged 1 commit intomicrosoft:mainfrom
dgozman:fix-pkg-imports-through-ts-paths
Aug 24, 2023
Merged

fix(resolver): allow importing packages with non-index main script#26692
dgozman merged 1 commit intomicrosoft:mainfrom
dgozman:fix-pkg-imports-through-ts-paths

Conversation

@dgozman
Copy link
Copy Markdown
Collaborator

@dgozman dgozman commented Aug 24, 2023

Regressed in #23254.

Fixes #26650.

@github-actions
Copy link
Copy Markdown
Contributor

Test results for "tests 1"

14 flaky
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-event-request.spec.ts:130:3 › should report navigation requests and responses handled by service worker with routing
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [playwright-test] › ui-mode-test-run.spec.ts:287:5 › should show time
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-event-request.spec.ts:130:3 › should report navigation requests and responses handled by service worker with routing
⚠️ [playwright-test] › ui-mode-test-progress.spec.ts:167:5 › should update tracing network live
⚠️ [webkit] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker
⚠️ [webkit] › library/selector-generator.spec.ts:51:5 › selector generator › should generate text for
⚠️ [webkit] › page/page-click.spec.ts:113:3 › should click the button after a cross origin navigation
⚠️ [webkit] › page/page-fill.spec.ts:171:3 › should fill elements with existing value and selection
⚠️ [webkit] › page/page-set-input-files.spec.ts:130:3 › should upload large file with relative path
⚠️ [webkit] › page/page-wait-for-load-state.spec.ts:124:3 › should work with clicking target=_blank

25167 passed, 584 skipped
✔️✔️✔️

Merge workflow run.

@dgozman dgozman merged commit c970179 into microsoft:main Aug 24, 2023
Germandrummer92 pushed a commit to OctoMind-dev/playwright that referenced this pull request Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[REGRESSION]: import with TypeScript path not resolved correctly since v1.35.0

2 participants