chore: miscellaneous trace viewer fixes#23695
Merged
aslushnikov merged 2 commits intomicrosoft:mainfrom Jun 14, 2023
Merged
Conversation
- properly annotate continued requests - nest `attach` steps inside the related `expect` step - fix primary-id-to-non-primary-id mapping - make sure images in trace are not draggable Fixes microsoft#23693
dgozman
approved these changes
Jun 14, 2023
Contributor
|
"tests 1" report. |
mxschmitt
reviewed
Jun 14, 2023
aslushnikov
commented
Jun 14, 2023
Co-authored-by: Max Schmitt <max@schmitt.mx> Signed-off-by: Andrey Lushnikov <aslushnikov@gmail.com>
aslushnikov
added a commit
that referenced
this pull request
Jun 14, 2023
- properly annotate continued requests - nest `attach` steps inside the related `expect` step - fix primary-id-to-non-primary-id mapping - make sure images in trace are not draggable Fixes #23693 --------- Signed-off-by: Andrey Lushnikov <aslushnikov@gmail.com> Co-authored-by: Max Schmitt <max@schmitt.mx>
Contributor
|
"tests 1" report. |
Contributor
|
"tests 1" report. |
Contributor
|
"tests 2" report. |
whazor
pushed a commit
to whazor/playwright-trace-viewer-plus
that referenced
this pull request
Jan 10, 2026
- properly annotate continued requests - nest `attach` steps inside the related `expect` step - fix primary-id-to-non-primary-id mapping - make sure images in trace are not draggable Fixes microsoft#23693 --------- Signed-off-by: Andrey Lushnikov <aslushnikov@gmail.com> Co-authored-by: Max Schmitt <max@schmitt.mx>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
attachsteps inside the relatedexpectstepFixes #23693