Skip to content

Conversation

@martinb35
Copy link
Contributor

previously both were doing two broadcast loops when they didn't need to since zero_point and scale get broadcast in the same manner. Also the code is simplified to not rely on the eigen templates unnecessarily.

@martinb35 martinb35 requested a review from a team as a code owner December 3, 2018 19:40
Copy link
Contributor

@RyanUnderhill RyanUnderhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the same changes made in internal review.

@martinb35 martinb35 merged commit 744ec28 into master Dec 4, 2018
@martinb35 martinb35 deleted the brian/quant branch December 4, 2018 16:39
TedThemistokleous added a commit to TedThemistokleous/onnxruntime that referenced this pull request Nov 12, 2024
…trib ops (microsoft#76)

Co-authored-by: Ted Themistokleous <tedthemistokleous@amd.com>
quic-ankus pushed a commit to CodeLinaro/onnxruntime that referenced this pull request Nov 25, 2025
[AISW-137623] MaxPool input rank-3 auto pad bug fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants