[webgpu][dawn API optimization] make less call to wgpuDeviceHasFeature #26474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the ShaderHelper class to store a reference to WebGpuContext instead of separate references to wgpu::Device and wgpu::Limits. This change improves encapsulation by centralizing device feature queries and device properties access through the context object.
- Replaced
device_and separatelimits_parameters with a singlewebgpu_context_reference inShaderHelper - Updated all
device_.HasFeature()calls to usewebgpu_context_.DeviceHasFeature()for consistency - Simplified the
ShaderHelperconstructor signature by passingWebGpuContextinstead of individual device components
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| webgpu_context.cc | Updated device feature checks to use DeviceHasFeature() method |
| shader_helper.h | Changed constructor and member variable from device_ and limits_ to webgpu_context_ |
| shader_helper.cc | Updated constructor, feature checks, and limits initialization to use webgpu_context_ |
| program_manager.cc | Simplified ShaderHelper construction by passing webgpu_context_ directly |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
guschmue
previously approved these changes
Nov 4, 2025
guschmue
approved these changes
Nov 5, 2025
Rohanjames1997
pushed a commit
to Rohanjames1997/onnxruntime
that referenced
this pull request
Dec 4, 2025
microsoft#26474) ### Description This is a following up change for microsoft#24281.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a following up change for #24281.