Fix python test issues for the 1.23.0 release #26118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes Python packaging test issues for the 1.23.0 release by addressing installation paths, expanding macOS test coverage, and enabling custom operator tests in the NuGet pipeline.
- Fixed pip install command in Linux smoking test to use correct wheel directory location
- Added comprehensive macOS test matrix covering Python 3.10-3.13 across macOS 13-15
- Enabled custom operator tests in Windows NuGet pipeline by downloading and placing required DLL
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| py-package-smoking-test-macos.yml | New parameterized template for macOS wheel testing |
| py-package-smoking-test-linux.yml | Fixed pip install path to use current directory |
| py-package-test-pipeline.yml | Expanded to use new macOS template with comprehensive test matrix |
| test_win.yml | Added custom operator DLL download and placement for NuGet tests |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
tools/ci_build/github/azure-pipelines/templates/py-package-smoking-test-macos.yml
Show resolved
Hide resolved
adrianlizarraga
approved these changes
Sep 24, 2025
apsonawane
approved these changes
Sep 25, 2025
snnn
pushed a commit
that referenced
this pull request
Oct 21, 2025
### Description 1. Fixes Python Wheel Installation Path: In the Linux smoking test (py-package-smoking-test-linux.yml), the pip install command was corrected to use --find-links . to locate the wheel in the correct directory. This resolves an issue where the installation script was looking in the wrong location. 2. Expands python package test pipeline's macOS Test Matrix: A new parameterized template (py-package-smoking-test-macos.yml) is introduced to test macOS wheels. The main pipeline (py-package-test-pipeline.yml) now uses this template to create a comprehensive test matrix, covering Python versions 3.10, 3.11, 3.12, and 3.13 across macOS versions 13, 14, and 15. 3. Enable more tests in Nuget Test Pipeline. The pipeline is for testing packaged ONNX Runtime nuget packages. In the Windows NuGet test template (test_win.yml), a step has been added to download and place the custom_op_library.dll in the appropriate test directory. This ensures the custom op tests can find their required dependencies. The SKIPNONPACKAGETESTS flag has been removed to ensure all such tests are run. ### Motivation and Context Improve packaging tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes Python Wheel Installation Path: In the Linux smoking test (py-package-smoking-test-linux.yml),
the pip install command was corrected to use --find-links . to locate the wheel in the correct directory.
This resolves an issue where the installation script was looking in the wrong location.
Expands python package test pipeline's macOS Test Matrix: A new parameterized template (py-package-smoking-test-macos.yml) is introduced to test macOS wheels. The main pipeline (py-package-test-pipeline.yml) now uses this template to create a comprehensive test matrix, covering Python versions 3.10, 3.11, 3.12, and 3.13 across macOS versions 13, 14, and 15.
Enable more tests in Nuget Test Pipeline. The pipeline is for testing packaged ONNX Runtime nuget packages. In the Windows NuGet test template (test_win.yml), a step has been added to download and place the custom_op_library.dll in the appropriate test directory. This ensures the custom op tests can find their required dependencies. The SKIPNONPACKAGETESTS flag has been removed to ensure all such tests are run.
Motivation and Context
Improve packaging tests.