Skip to content

[webgpu] fix the reflect mode issue of Pad #24202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
guschmue merged 2 commits into from
Apr 8, 2025
Merged

[webgpu] fix the reflect mode issue of Pad #24202

guschmue merged 2 commits into from
Apr 8, 2025

Conversation

@xhcao
Copy link
Contributor

@xhcao xhcao commented Mar 27, 2025

Description

Motivation and Context

@xhcao
Copy link
Contributor Author

xhcao commented Mar 27, 2025

The patch fixes these three Pad - Reflect 1D, Pad - Reflect 2D Pad - Reflect 3D failed cases https://dev.azure.com/onnxruntime/onnxruntime/_build/results?buildId=1655103&view=results, which webgpu EP run js EP cases.
Actually, these JS cases also fail on CPU and CUDA EPs, The reflected element in tensor is from another reflected element, and the two EPs do not consider this situation.
But this situation is not prohibited by the Pad operator spec, so fix it.
@jchen10 @hujiajie PTAL, thanks

@guschmue guschmue added the ep:WebGPU ort-web webgpu provider label Mar 27, 2025
@guschmue
Copy link
Contributor

guschmue commented Mar 27, 2025

/azp run ONNX Runtime Web CI Pipeline,Windows GPU CI Pipeline,Linux Android Emulator QNN CI Pipeline

@guschmue
Copy link
Contributor

guschmue commented Mar 27, 2025

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline, Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

@azure-pipelines
Copy link

azure-pipelines bot commented Mar 27, 2025

Azure Pipelines successfully started running 2 pipeline(s).

@guschmue
Copy link
Contributor

guschmue commented Mar 27, 2025

/azp run Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline,Big Models

@guschmue
Copy link
Contributor

guschmue commented Mar 27, 2025

/azp run Windows GPU CUDA CI Pipeline,Windows GPU DML CI Pipeline,Windows GPU Doc Gen CI Pipeline, Win_TRT_Minimal_CUDA_Test_CI

@azure-pipelines
Copy link

azure-pipelines bot commented Mar 27, 2025

Azure Pipelines successfully started running 3 pipeline(s).

@azure-pipelines
Copy link

azure-pipelines bot commented Mar 27, 2025

Azure Pipelines successfully started running 6 pipeline(s).

@azure-pipelines
Copy link

azure-pipelines bot commented Mar 27, 2025

Azure Pipelines successfully started running 2 pipeline(s).

@guschmue
Copy link
Contributor

guschmue commented Mar 31, 2025

/azp run wasm_Debug / build-wasm, wasm_Release / build-wasm, web_Debug / build_onnxruntime_web, web_Release / build_onnxruntime_web, webgpu / build-and-test (x86_64, Debug)

@azure-pipelines
Copy link

azure-pipelines bot commented Mar 31, 2025

No pipelines are associated with this pull request.

@guschmue
Copy link
Contributor

guschmue commented Mar 31, 2025

Sorry, needs to be merged with main ... some pipelines changed.

@xhcao
Copy link
Contributor Author

xhcao commented Apr 1, 2025

Sorry, needs to be merged with main ... some pipelines changed.

Updated

@guschmue
Copy link
Contributor

guschmue commented Apr 7, 2025

/azp run Linux QNN CI Pipeline,Win_TRT_Minimal_CUDA_Test_CI,Windows ARM64 QNN CI Pipeline,Windows x64 QNN CI Pipeline

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 7, 2025

Azure Pipelines successfully started running 4 pipeline(s).

@guschmue
Copy link
Contributor

guschmue commented Apr 8, 2025

/azp run Windows GPU Doc Gen CI Pipeline

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 8, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@guschmue guschmue merged commit 10e51d2 into microsoft:main Apr 8, 2025
60 of 69 checks passed
zhaoxul-qti pushed a commit to CodeLinaro/onnxruntime that referenced this pull request Apr 17, 2025
@xhcao @zhaoxul-qti
[webgpu] fix the reflect mode issue of Pad (microsoft#24202)
56f9947 
### Description
<!-- Describe your changes. -->



### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guschmue guschmue guschmue approved these changes

Assignees

No one assigned

Labels

ep:WebGPU ort-web webgpu provider

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xhcao @guschmue