Skip to content

Conversation

@edgchen1
Copy link
Contributor

Description

Look up and use absolute path of libcdsprpc.dll on Windows.

Motivation and Context

The QNN EP's HTP shared memory allocator requires use of the libcdsprpc shared library.

On Windows, this previously required copying libcdsprpc.dll from some driver-specific path to somewhere the running code could find it. After this change, libcdsprpc.dll no longer needs to be copied.

Copy link
Contributor

@quic-ashigarg quic-ashigarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@HectorSVC HectorSVC merged commit e46c0d8 into main Feb 24, 2025
97 of 99 checks passed
@HectorSVC HectorSVC deleted the edgchen1/get_libcdsprpc_dll_path branch February 24, 2025 06:20
amarin16 pushed a commit that referenced this pull request Feb 27, 2025
… need to be copied anywhere. (#23791)

### Description
Look up and use absolute path of libcdsprpc.dll on Windows.

### Motivation and Context
The QNN EP's HTP shared memory allocator requires use of the libcdsprpc shared library.
On Windows, this previously required copying libcdsprpc.dll from some driver-specific path to somewhere the running code could find it. After this change, libcdsprpc.dll no longer needs to be copied.
amarin16 pushed a commit that referenced this pull request Feb 27, 2025
… need to be copied anywhere. (#23791)

### Description
Look up and use absolute path of libcdsprpc.dll on Windows.

### Motivation and Context
The QNN EP's HTP shared memory allocator requires use of the libcdsprpc shared library.
On Windows, this previously required copying libcdsprpc.dll from some driver-specific path to somewhere the running code could find it. After this change, libcdsprpc.dll no longer needs to be copied.
amarin16 added a commit that referenced this pull request Feb 28, 2025
Cherry-pick the following changes into
[rel-1.21.0](https://github.com/microsoft/onnxruntime/tree/rel-1.21.0).
- (#23791)
- (#23710)
- (#23789)
- (#23829)

---------

Co-authored-by: Edward Chen <18449977+edgchen1@users.noreply.github.com>
Co-authored-by: Yifan Li <109183385+yf711@users.noreply.github.com>
Co-authored-by: Ankit Maheshkar <ankit.maheshkar@intel.com>
Co-authored-by: n1harika <niharika.sathish@intel.com>
Co-authored-by: Changming Sun <chasun@microsoft.com>
guschmue pushed a commit that referenced this pull request Mar 6, 2025
… need to be copied anywhere. (#23791)

### Description
Look up and use absolute path of libcdsprpc.dll on Windows.

### Motivation and Context
The QNN EP's HTP shared memory allocator requires use of the libcdsprpc shared library.
On Windows, this previously required copying libcdsprpc.dll from some driver-specific path to somewhere the running code could find it. After this change, libcdsprpc.dll no longer needs to be copied.
ashrit-ms pushed a commit that referenced this pull request Mar 17, 2025
Cherry-pick the following changes into
[rel-1.21.0](https://github.com/microsoft/onnxruntime/tree/rel-1.21.0).
- (#23791)
- (#23710)
- (#23789)
- (#23829)

---------

Co-authored-by: Edward Chen <18449977+edgchen1@users.noreply.github.com>
Co-authored-by: Yifan Li <109183385+yf711@users.noreply.github.com>
Co-authored-by: Ankit Maheshkar <ankit.maheshkar@intel.com>
Co-authored-by: n1harika <niharika.sathish@intel.com>
Co-authored-by: Changming Sun <chasun@microsoft.com>
ankitm3k added a commit to intel/onnxruntime that referenced this pull request Apr 10, 2025
Cherry-pick the following changes into
[rel-1.21.0](https://github.com/microsoft/onnxruntime/tree/rel-1.21.0).
- (microsoft#23791)
- (microsoft#23710)
- (microsoft#23789)
- (microsoft#23829)

---------

Co-authored-by: Edward Chen <18449977+edgchen1@users.noreply.github.com>
Co-authored-by: Yifan Li <109183385+yf711@users.noreply.github.com>
Co-authored-by: Ankit Maheshkar <ankit.maheshkar@intel.com>
Co-authored-by: n1harika <niharika.sathish@intel.com>
Co-authored-by: Changming Sun <chasun@microsoft.com>
@snnn
Copy link
Contributor

snnn commented Sep 5, 2025

This PR has been cherry-picked into the rel-1.21.0 branch in PR #23846. Removing the release:1.21.0 label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants