Skip to content

[AIX]eigen update fix and test failures fix #23751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
snnn merged 3 commits into from
Feb 20, 2025
Merged

[AIX]eigen update fix and test failures fix #23751

snnn merged 3 commits into from
Feb 20, 2025

Conversation

@ranjitshs
Copy link
Contributor

@ranjitshs ranjitshs commented Feb 19, 2025

Description

Changes in this PR are for:

  • Cleanup the patch for Eigen on AIX. Not needed anymore .
  • Fix to recent test failures
1: [----------] Global test environment tear-down
1: [==========] 4737 tests from 310 test suites ran. (94682 ms total)
1: [  PASSED  ] 4733 tests.
1: [  SKIPPED ] 2 tests, listed below:
1: [  SKIPPED ] MatMulFpQ4.MatMul2DSym
1: [  SKIPPED ] MatMulFpQ4.MatMul2DBlkZp
1: [  FAILED  ] 2 tests, listed below:
1: [  FAILED  ] GraphTransformationTests.MatMulAddFusion_three_input_with_1d
1: [  FAILED  ] GraphTransformationTests.MatMulAddFusion_NeedReshape_3D

@ranjitshs
Copy link
Contributor Author

ranjitshs commented Feb 19, 2025

@snnn @tianleiwu
Please review this change and let me know if any comments.
Also, Please trigger CI workflows.

@tianleiwu
Copy link
Contributor

tianleiwu commented Feb 19, 2025

/azp run Windows ARM64 QNN CI Pipeline,Windows x64 QNN CI Pipeline,Windows CPU CI Pipeline,Windows GPU CUDA CI Pipeline,Windows GPU DML CI Pipeline,Windows GPU Doc Gen CI Pipeline,Windows GPU TensorRT CI Pipeline,ONNX Runtime Web CI Pipeline,Win_TRT_Minimal_CUDA_Test_CI,Linux CPU CI Pipeline

@tianleiwu
Copy link
Contributor

tianleiwu commented Feb 19, 2025

/azp run Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,Big Models,Linux Android Emulator QNN CI Pipeline,Android CI Pipeline

@tianleiwu
Copy link
Contributor

tianleiwu commented Feb 19, 2025

/azp run iOS CI Pipeline,ONNX Runtime React Native CI Pipeline,CoreML CI Pipeline,Linux DNNL CI Pipeline,Linux MIGraphX CI Pipeline,Linux ROCm CI Pipeline

@azure-pipelines
Copy link

azure-pipelines bot commented Feb 19, 2025

Azure Pipelines successfully started running 6 pipeline(s).

@azure-pipelines
Copy link

azure-pipelines bot commented Feb 19, 2025

Azure Pipelines successfully started running 10 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

azure-pipelines bot commented Feb 19, 2025

Azure Pipelines successfully started running 10 pipeline(s).

@snnn
Copy link
Contributor

snnn commented Feb 19, 2025

/azp run Linux GPU CI Pipeline

@azure-pipelines
Copy link

azure-pipelines bot commented Feb 19, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@yuslepukhin
Copy link
Member

yuslepukhin commented Feb 19, 2025

LGTM, but needs lintrunner -a, and CI to pass.

snnn
snnn previously approved these changes Feb 20, 2025
View reviewed changes
@snnn
Copy link
Contributor

snnn commented Feb 20, 2025

Please help fix the "Lint / Python format (pull_request)" error.

tianleiwu
tianleiwu reviewed Feb 20, 2025
View reviewed changes
tianleiwu
tianleiwu reviewed Feb 20, 2025
View reviewed changes
@tianleiwu
Copy link
Contributor

tianleiwu commented Feb 20, 2025

/azp run Windows ARM64 QNN CI Pipeline,Windows x64 QNN CI Pipeline,Windows CPU CI Pipeline,Windows GPU CUDA CI Pipeline,Windows GPU DML CI Pipeline,Windows GPU Doc Gen CI Pipeline,Windows GPU TensorRT CI Pipeline,ONNX Runtime Web CI Pipeline,Win_TRT_Minimal_CUDA_Test_CI,Linux CPU CI Pipeline

@tianleiwu
Copy link
Contributor

tianleiwu commented Feb 20, 2025

/azp run Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,Big Models,Linux Android Emulator QNN CI Pipeline,Android CI Pipeline

@tianleiwu
Copy link
Contributor

tianleiwu commented Feb 20, 2025

/azp run iOS CI Pipeline,ONNX Runtime React Native CI Pipeline,CoreML CI Pipeline,Linux DNNL CI Pipeline,Linux MIGraphX CI Pipeline,Linux ROCm CI Pipeline

@azure-pipelines
Copy link

azure-pipelines bot commented Feb 20, 2025

Azure Pipelines successfully started running 6 pipeline(s).

@azure-pipelines
Copy link

azure-pipelines bot commented Feb 20, 2025

Azure Pipelines successfully started running 10 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

azure-pipelines bot commented Feb 20, 2025

Azure Pipelines successfully started running 10 pipeline(s).

@ranjitshs
Copy link
Contributor Author

ranjitshs commented Feb 20, 2025 •
edited
Loading

Thanks @tianleiwu for committing lint fix.
I ran 'lintrunner -a' and it's not suggesting any changes.

@snnn snnn merged commit 6036210 into microsoft:main Feb 20, 2025
89 of 91 checks passed
@ranjitshs ranjitshs deleted the aix-eigen-cleanup branch February 21, 2025 06:06
guschmue pushed a commit that referenced this pull request Mar 6, 2025
@ranjitshs @tianleiwu @guschmue
[AIX]eigen update fix and test failures fix (#23751)
2815c4d 
### Description
Changes in this PR are for:

- Cleanup the patch for Eigen on AIX. Not needed anymore .
- Fix to recent test failures

```
1: [----------] Global test environment tear-down
1: [==========] 4737 tests from 310 test suites ran. (94682 ms total)
1: [  PASSED  ] 4733 tests.
1: [  SKIPPED ] 2 tests, listed below:
1: [  SKIPPED ] MatMulFpQ4.MatMul2DSym
1: [  SKIPPED ] MatMulFpQ4.MatMul2DBlkZp
1: [  FAILED  ] 2 tests, listed below:
1: [  FAILED  ] GraphTransformationTests.MatMulAddFusion_three_input_with_1d
1: [  FAILED  ] GraphTransformationTests.MatMulAddFusion_NeedReshape_3D
```

---------

Co-authored-by: Tianlei Wu <tlwu@microsoft.com>
ashrit-ms pushed a commit that referenced this pull request Mar 17, 2025
@ranjitshs @tianleiwu @ashrit-ms
[AIX]eigen update fix and test failures fix (#23751)
d365f50 
### Description
Changes in this PR are for:

- Cleanup the patch for Eigen on AIX. Not needed anymore .
- Fix to recent test failures

```
1: [----------] Global test environment tear-down
1: [==========] 4737 tests from 310 test suites ran. (94682 ms total)
1: [  PASSED  ] 4733 tests.
1: [  SKIPPED ] 2 tests, listed below:
1: [  SKIPPED ] MatMulFpQ4.MatMul2DSym
1: [  SKIPPED ] MatMulFpQ4.MatMul2DBlkZp
1: [  FAILED  ] 2 tests, listed below:
1: [  FAILED  ] GraphTransformationTests.MatMulAddFusion_three_input_with_1d
1: [  FAILED  ] GraphTransformationTests.MatMulAddFusion_NeedReshape_3D
```

---------

Co-authored-by: Tianlei Wu <tlwu@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tianleiwu tianleiwu tianleiwu left review comments

+1 more reviewer

@snnn snnn snnn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ranjitshs @tianleiwu @snnn @yuslepukhin