Fix an installation issue related to absl #23641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baijumeswani
approved these changes
Feb 11, 2025
snnn
pushed a commit
that referenced
this pull request
Feb 27, 2025
amarin16
pushed a commit
that referenced
this pull request
Feb 27, 2025
amarin16
pushed a commit
that referenced
this pull request
Feb 27, 2025
guschmue
pushed a commit
that referenced
this pull request
Mar 6, 2025
The extra word after the "FIND_PACKAGE_ARGS" keyword would be silently ignored by CMake. The issue was introduced in PR #23426 on February 5, 2025. Intel engineers reported this issue to us on February 10, 2025. Without this fix, you may see errors like: ``` CMake Error at cmake_install.cmake:47 (include): include could not find requested file: /home/abc/src/onnxruntime/f58/Debug/_deps/abseil_cpp-build/cmake_install.cmake ``` When running "make install" command after successfully building onnxruntime without vcpkg. The issue doesn't exist when vcpkg is enabled.
guschmue
pushed a commit
that referenced
this pull request
Mar 6, 2025
ashrit-ms
pushed a commit
that referenced
this pull request
Mar 17, 2025
The extra word after the "FIND_PACKAGE_ARGS" keyword would be silently ignored by CMake. The issue was introduced in PR #23426 on February 5, 2025. Intel engineers reported this issue to us on February 10, 2025. Without this fix, you may see errors like: ``` CMake Error at cmake_install.cmake:47 (include): include could not find requested file: /home/abc/src/onnxruntime/f58/Debug/_deps/abseil_cpp-build/cmake_install.cmake ``` When running "make install" command after successfully building onnxruntime without vcpkg. The issue doesn't exist when vcpkg is enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was not my first time making such errors: the extra word after the "FIND_PACKAGE_ARGS" keyword would be silently ignored by CMake. For example, when you review this change, you see "EXCLUDE_FROM_ALL" string is highlighted by Github, right? Yes, it is a keyword. But all such keywords must be before the FIND_PACKAGE_ARGS string.
The issue was introduced in PR #23426 on February 5, 2025. Intel engineers reported this issue to us on February 10, 2025. Without this fix, you may see errors like:
When running "make install" command after successfully building onnxruntime without vcpkg.
The issue doesn't exist when vcpkg is enabled.