Update xnnpack, cpuinfo and pthreadpool #23362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 14, 2025 09:50
jywu-msft
reviewed
Jan 15, 2025
Member
|
I recently came to realize that https://github.com/microsoft/onnxruntime/blob/73f5b0c5976fec04ebbdfe0761ee23055e0fcf8b/onnxruntime/core/common/cpuid_uarch.cc is basically a copy of https://github.com/pytorch/cpuinfo/blob/main/src/arm/uarch.c |
Contributor
Author
|
I did not know that, will address it in another PR and ask the MLAS team to help review. |
jywu-msft
approved these changes
Jan 15, 2025
carzh
pushed a commit
that referenced
this pull request
Jan 16, 2025
### Description Update xnnpack to remove the dependency on psimd and fp16 libraries. However, coremltool still depends on them, which will be addressed later. Also, update CPUINFO because the latest xnnpack requires CPUINFO's avx10 support. ### Motivation and Context The fewer dependencies the better.
guschmue
pushed a commit
that referenced
this pull request
Mar 6, 2025
### Description Update xnnpack to remove the dependency on psimd and fp16 libraries. However, coremltool still depends on them, which will be addressed later. Also, update CPUINFO because the latest xnnpack requires CPUINFO's avx10 support. ### Motivation and Context The fewer dependencies the better.
ashrit-ms
pushed a commit
that referenced
this pull request
Mar 17, 2025
### Description Update xnnpack to remove the dependency on psimd and fp16 libraries. However, coremltool still depends on them, which will be addressed later. Also, update CPUINFO because the latest xnnpack requires CPUINFO's avx10 support. ### Motivation and Context The fewer dependencies the better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update xnnpack to remove the dependency on psimd and fp16 libraries. However, coremltool still depends on them, which will be addressed later.
Also, update CPUINFO because the latest xnnpack requires CPUINFO's avx10 support.
Motivation and Context
The fewer dependencies the better.