Skip to content

sign native dll with correct cert#21854

Merged
mszhanyi merged 1 commit intomainfrom
zhanyi/signdll
Aug 26, 2024
Merged

sign native dll with correct cert#21854
mszhanyi merged 1 commit intomainfrom
zhanyi/signdll

Conversation

@mszhanyi
Copy link
Copy Markdown
Contributor

@mszhanyi mszhanyi commented Aug 26, 2024

Description

Fixed #21775

Motivation and Context

The dlls should be signed with Keycode CP-230012.
The default is the test code sign.

@mszhanyi mszhanyi requested a review from a team August 26, 2024 03:48
@mszhanyi mszhanyi merged commit 2877de7 into main Aug 26, 2024
@mszhanyi mszhanyi deleted the zhanyi/signdll branch August 26, 2024 08:46
prathikr pushed a commit that referenced this pull request Aug 26, 2024
### Description
Fixed #21775



### Motivation and Context
The dlls should be signed with Keycode CP-230012.
The default is the test code sign.
yufenglee pushed a commit to microsoft/onnxruntime-genai that referenced this pull request Aug 27, 2024
The default sign key is test code sign key.
The PR is same as microsoft/onnxruntime#21854

Co-authored-by: Yi Zhang <your@email.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Why ONNX Runtime Dlls are not Signed by Microsoft

2 participants