Skip to content

Revert NeuralSpeed code for x64 MatMulNBits #19382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
snnn merged 3 commits into from
Feb 7, 2024
Merged

Revert NeuralSpeed code for x64 MatMulNBits #19382

snnn merged 3 commits into from
Feb 7, 2024

Conversation

@luoyu-intel
Copy link
Contributor

@luoyu-intel luoyu-intel commented Feb 2, 2024

Description

Revert PR#19016 #19016
Revert PR#17669 #17669

Motivation and Context

The code will be fully tested and reviewed. After that, my colleagues will work on a new PR.

@luoyu-intel luoyu-intel marked this pull request as ready for review February 2, 2024 04:08
@luoyu-intel luoyu-intel requested a review from a team as a code owner February 2, 2024 04:08
@tianleiwu
Copy link
Contributor

tianleiwu commented Feb 6, 2024

/azp run Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Linux OpenVINO CI Pipeline, MacOS CI Pipeline, ONNX Runtime Web CI Pipeline, onnxruntime-binary-size-checks-ci-pipeline, Linux QNN CI Pipeline

@tianleiwu
Copy link
Contributor

tianleiwu commented Feb 6, 2024

/azp run Windows CPU CI Pipeline, Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline, Windows ARM64 QNN CI Pipeline, orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline, orttraining-ortmodule-distributed, ONNX Runtime React Native CI Pipeline, Windows x64 QNN CI Pipeline

@tianleiwu
Copy link
Contributor

tianleiwu commented Feb 6, 2024

/azp run Linux MIGraphX CI Pipeline, orttraining-amd-gpu-ci-pipeline

@azure-pipelines
Copy link

azure-pipelines bot commented Feb 6, 2024

Azure Pipelines successfully started running 2 pipeline(s).

@azure-pipelines
Copy link

azure-pipelines bot commented Feb 6, 2024

Azure Pipelines successfully started running 9 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

azure-pipelines bot commented Feb 6, 2024

Azure Pipelines successfully started running 9 pipeline(s).

@tianleiwu
Copy link
Contributor

tianleiwu commented Feb 7, 2024

@pranavsharma, @faxu, this PR need onnxruntime-admin approval before merging. Please take a look.

@snnn snnn merged commit 0d10c7f into microsoft:main Feb 7, 2024
snnn pushed a commit that referenced this pull request Feb 8, 2024
Revert "Revert NeuralSpeed code for x64 MatMulNBits (#19382)"
fcd9b8c 
This reverts commit 0d10c7f.
snnn pushed a commit that referenced this pull request Feb 9, 2024
Revert "Revert NeuralSpeed code for x64 MatMulNBits (#19382)" (#19474)
1007d8f 
This reverts commit 0d10c7f.
skottmckay pushed a commit that referenced this pull request Feb 15, 2024
@luoyu-intel @skottmckay
Revert NeuralSpeed code for x64 MatMulNBits (#19382)
c10d6a4 
### Description
<!-- Describe your changes. -->
Revert PR#19016 #19016
Revert PR#17669 #17669
skottmckay pushed a commit that referenced this pull request Feb 15, 2024
@skottmckay
Revert "Revert NeuralSpeed code for x64 MatMulNBits (#19382)" (#19474)
a341b2e 
This reverts commit 0d10c7f.
@leso-kn
Copy link
Contributor

leso-kn commented Sep 29, 2025

Hi! Sorry to bump this, but is it possible that this could still affect aarch64 on musl?

Alpine Linux aarch64 build job log: https://gitlab.alpinelinux.org/leso-kn/aports/-/jobs/2031484

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@snnn snnn snnn approved these changes

@pranavsharma pranavsharma pranavsharma approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@luoyu-intel @tianleiwu @leso-kn @snnn @pranavsharma