Skip to content

[JS/WebGPU] fix an error in Clip #18799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
satyajandhyala merged 5 commits into from
Dec 19, 2023
Merged

[JS/WebGPU] fix an error in Clip #18799

satyajandhyala merged 5 commits into from
Dec 19, 2023

Conversation

@satyajandhyala
Copy link
Contributor

@satyajandhyala satyajandhyala commented Dec 13, 2023

Description

Motivation and Context

fs-eire
fs-eire reviewed Dec 13, 2023
View reviewed changes
fs-eire
fs-eire reviewed Dec 13, 2023
View reviewed changes
@satyajandhyala satyajandhyala changed the title Sajandhy/webgpu fix clip [WIP][JS/WebGPU] fix clip Dec 13, 2023
@satyajandhyala satyajandhyala changed the title [WIP][JS/WebGPU] fix clip [JS/WebGPU] fix clip Dec 13, 2023
@satyajandhyala satyajandhyala changed the title [JS/WebGPU] fix clip [JS/WebGPU] fix an error in Clip Dec 13, 2023
@satyajandhyala satyajandhyala marked this pull request as ready for review December 13, 2023 18:21
qjia7
qjia7 reviewed Dec 14, 2023
View reviewed changes
@satyajandhyala satyajandhyala added the ep:WebGPU ort-web webgpu provider label Dec 15, 2023
@satyajandhyala satyajandhyala merged commit 98510fb into main Dec 19, 2023
@satyajandhyala satyajandhyala deleted the sajandhy/webgpu_fix_clip branch December 19, 2023 21:51
siweic0 pushed a commit to siweic0/onnxruntime-web that referenced this pull request May 9, 2024
@satyajandhyala
[JS/WebGPU] fix an error in Clip (microsoft#18799)
3971003 
### Description
<!-- Describe your changes. -->
Check whether the min/max inputs are provided and use default values if not provided.


### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qjia7 qjia7 qjia7 left review comments

@guschmue guschmue guschmue approved these changes

@fs-eire fs-eire Awaiting requested review from fs-eire

Assignees

No one assigned

Labels

ep:WebGPU ort-web webgpu provider

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@satyajandhyala @qjia7 @fs-eire @guschmue