Skip to content

[JS/Web]Added uniforms support to Slice op. #18422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
satyajandhyala merged 13 commits into from
Nov 16, 2023
Merged

[JS/Web]Added uniforms support to Slice op. #18422

satyajandhyala merged 13 commits into from
Nov 16, 2023

Conversation

@satyajandhyala
Copy link
Contributor

@satyajandhyala satyajandhyala commented Nov 14, 2023

Description

Support uniforms in Slice op

Motivation and Context

Improve ferformance

@satyajandhyala satyajandhyala changed the title Added uniforms support to Slice op. [WIP/not ready for review][JS/Web]Added uniforms support to Slice op. Nov 14, 2023
@satyajandhyala satyajandhyala changed the title [WIP/not ready for review][JS/Web]Added uniforms support to Slice op. [WIP][JS/Web]Added uniforms support to Slice op. Nov 14, 2023
@satyajandhyala satyajandhyala added the ep:WebGPU ort-web webgpu provider label Nov 14, 2023
@satyajandhyala satyajandhyala force-pushed the sajandhy/webgpu_unifroms_suppot_slice branch from 1ce5c1b to 4130747 Compare November 14, 2023 20:06
@satyajandhyala satyajandhyala force-pushed the sajandhy/webgpu_unifroms_suppot_slice branch from 4130747 to cc163d1 Compare November 14, 2023 20:16
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 15, 2023
View reviewed changes
@satyajandhyala satyajandhyala marked this pull request as ready for review November 15, 2023 00:20
@satyajandhyala satyajandhyala force-pushed the sajandhy/webgpu_unifroms_suppot_slice branch from 37adaa5 to b745c61 Compare November 15, 2023 00:25
@satyajandhyala satyajandhyala changed the title [WIP][JS/Web]Added uniforms support to Slice op. [JS/Web]Added uniforms support to Slice op. Nov 15, 2023
qjia7
qjia7 reviewed Nov 16, 2023
View reviewed changes
qjia7
qjia7 approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@qjia7 qjia7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@satyajandhyala satyajandhyala merged commit b291b20 into main Nov 16, 2023
@satyajandhyala satyajandhyala deleted the sajandhy/webgpu_unifroms_suppot_slice branch November 16, 2023 17:44
kleiti pushed a commit to kleiti/onnxruntime that referenced this pull request Mar 22, 2024
@satyajandhyala @kleiti
[JS/Web]Added uniforms support to Slice op. (microsoft#18422)
8aa005a 
### Description
Support uniforms in Slice op



### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
Improve ferformance
siweic0 pushed a commit to siweic0/onnxruntime-web that referenced this pull request May 9, 2024
@satyajandhyala
[JS/Web]Added uniforms support to Slice op. (microsoft#18422)
068a939 
### Description
Support uniforms in Slice op



### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
Improve ferformance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qjia7 qjia7 qjia7 approved these changes

@guschmue guschmue guschmue approved these changes

@fs-eire fs-eire Awaiting requested review from fs-eire

Assignees

No one assigned

Labels

ep:WebGPU ort-web webgpu provider

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@satyajandhyala @qjia7 @guschmue