[QNN EP] Disable early termination in GetCapability#18140
Merged
Conversation
…ion and context cache enabled
adrianlizarraga
approved these changes
Oct 30, 2023
kleiti
pushed a commit
to kleiti/onnxruntime
that referenced
this pull request
Mar 22, 2024
[QNN EP] Disable early termination in GetCapability if there are multiple partition and context binary enabled ### Description QNN EP context binary cache feature only support single partition for now. We have early termination in GetCapability. After the PR microsoft#17764. There's no Level 1 optimization any more for the 1st GetCapability. Graph transformer EnsureUniqueDQForNodeUnit is not applied. So if there's initializer -> DQ -> shared by multiple node unit. The node is not identified as node unit group. QNN EP report many not supported nodes because of this in the 1st GetCapability call. The 2nd GetCapability still works normally. Disable the early termination in GetCapability, delay the decision to Compile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[QNN EP] Disable early termination in GetCapability if there are multiple partition and context binary enabled
Description
QNN EP context binary cache feature only support single partition for now. We have early termination in GetCapability.
After the PR #17764. There's no Level 1 optimization any more for the 1st GetCapability. Graph transformer EnsureUniqueDQForNodeUnit is not applied. So if there's initializer -> DQ -> shared by multiple node unit. The node is not identified as node unit group. QNN EP report many not supported nodes because of this in the 1st GetCapability call.
The 2nd GetCapability still works normally.
Disable the early termination in GetCapability, delay the decision to Compile.