[QNN EP] Fix index-out-of-bounds bug in Slice builder when initializer is shared#17905
Merged
adrianlizarraga merged 7 commits intomainfrom Oct 13, 2023
Merged
Conversation
adrianlizarraga
commented
Oct 12, 2023
adrianlizarraga
commented
Oct 12, 2023
yuslepukhin
reviewed
Oct 12, 2023
onnxruntime/core/providers/qnn/builder/opbuilder/slice_op_builder.cc
Outdated
Show resolved
Hide resolved
yuslepukhin
reviewed
Oct 12, 2023
onnxruntime/core/providers/qnn/builder/opbuilder/slice_op_builder.cc
Outdated
Show resolved
Hide resolved
yuslepukhin
reviewed
Oct 12, 2023
yuslepukhin
previously approved these changes
Oct 12, 2023
yuslepukhin
approved these changes
Oct 13, 2023
HectorSVC
approved these changes
Oct 13, 2023
jchen351
pushed a commit
that referenced
this pull request
Oct 18, 2023
…r is shared (#17905) ### Description There's an index-out-of-bounds bug that is triggered when a Slice operator shares an initializer with another operator that is processed first. In this case, QNN EP fails to properly initialize a `raw_starts` (or `raw_ends`) vector, which is later indexed by a call to `SliceOp::PrepareForComputeHelper()`. ### Motivation and Context Fix bug that blocks #17764
kleiti
pushed a commit
to kleiti/onnxruntime
that referenced
this pull request
Mar 22, 2024
…r is shared (microsoft#17905) ### Description There's an index-out-of-bounds bug that is triggered when a Slice operator shares an initializer with another operator that is processed first. In this case, QNN EP fails to properly initialize a `raw_starts` (or `raw_ends`) vector, which is later indexed by a call to `SliceOp::PrepareForComputeHelper()`. ### Motivation and Context Fix bug that blocks microsoft#17764
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There's an index-out-of-bounds bug that is triggered when a Slice operator shares an initializer with another operator that is processed first. In this case, QNN EP fails to properly initialize a
raw_starts(orraw_ends) vector, which is later indexed by a call toSliceOp::PrepareForComputeHelper().Motivation and Context
Fix bug that blocks #17764