Skip to content

Fix illegal opcode error from mlas#17885

Merged
skottmckay merged 2 commits intomainfrom
skottmckay/FixIllegalOpcodeErrorFromMLAS
Oct 12, 2023
Merged

Fix illegal opcode error from mlas#17885
skottmckay merged 2 commits intomainfrom
skottmckay/FixIllegalOpcodeErrorFromMLAS

Conversation

@skottmckay
Copy link
Contributor

Description

Use cpuinfo value when checking to dot product is available. Reading the ID_AA64ISAR0_EL1 register is unsafe.

Motivation and Context

#17647
#17541
#17851

@skottmckay skottmckay requested a review from a team as a code owner October 11, 2023 05:29
@skottmckay skottmckay changed the title Skottmckay/fix illegal opcode error from mlas Fix illegal opcode error from mlas Oct 11, 2023
@skottmckay skottmckay merged commit ba7f20a into main Oct 12, 2023
@skottmckay skottmckay deleted the skottmckay/FixIllegalOpcodeErrorFromMLAS branch October 12, 2023 22:27
snnn pushed a commit that referenced this pull request Nov 2, 2023
Cherry-pick PRs: 
#18026 
#17912 
#17901 “2 lines added whitespace errors when cherry-picking"
#17293 
#17364 
#17505 
#17885

This PR contains all the cherry-picks for the patch release except:
1. The PRs marked with sdxl_llama
2. #17772 which has a merge conflict.

---------

Co-authored-by: Chi Lo <Chi.Lo@microsoft.com>
Co-authored-by: Chi Lo <54722500+chilo-ms@users.noreply.github.com>
Co-authored-by: Scott McKay <Scott.McKay@microsoft.com>
Co-authored-by: Baiju Meswani <bmeswani@microsoft.com>
Co-authored-by: Kaz Nishimura <kazssym@linuxfront.com>
Co-authored-by: Scott McKay <skottmckay@gmail.com>
kleiti pushed a commit to kleiti/onnxruntime that referenced this pull request Mar 22, 2024
### Description
<!-- Describe your changes. -->
Use cpuinfo value when checking to dot product is available. Reading the
ID_AA64ISAR0_EL1 register is unsafe.

### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
microsoft#17647 
microsoft#17541 
microsoft#17851
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants