Conversation
Contributor
BowenBao
commented
Sep 4, 2019
- Update onnxruntime/protobuf/onnx.in.proto with changes for SparseTensor.
- Bump onnx to latest to include new opset 11 ops (det, scatternd, gathernd, etc.)
Merged
Member
|
This PR is missing significant code changes. One must go through all of the switch() or if/else statements where attribute types are being handles and also oneof value within TensorType to make sure that SparseTensor is properly handled. |
yuslepukhin
reviewed
Sep 9, 2019
Member
There was a problem hiding this comment.
initializer [](start = 23, length = 11)
Check for places in the code that deal with initializer and see if we need to add handling for sparse initializer
yuslepukhin
reviewed
Sep 9, 2019
3ceb39b to
09500f0
Compare
hariharans29
reviewed
Sep 9, 2019
hariharans29
requested changes
Sep 9, 2019
Update onnx.in.proto with changes for SparseTensor.
50ed95f to
386a88a
Compare
hariharans29
approved these changes
Sep 11, 2019
Contributor
Author
|
CI failure seems unrelated.. |
Member
Yes, those failures are transitory. You just need to re-run them, possibly outside business hours. This happened to my PRs as well. |
yuslepukhin
pushed a commit
that referenced
this pull request
Mar 17, 2026
## Describe your changes 1. Print CLI output model save path (not sure why this was removed before). 2. Add `input_cols` option to dataset for cli for text-classification task. 3. Update error message when missing dataset, otherwise it will say the precision is not supported. 4. Save `hf_task` to `model_attributes` from Conversion pass, this will be used for later pass. 5. Correct model name and task for dataset config when input model is `onnxmodel`. ## Checklist before requesting a review - [ ] Add unit tests for this change. - [ ] Make sure all tests can pass. - [ ] Update documents if necessary. - [ ] Lint and apply fixes to your code by running `lintrunner -a` - [ ] Is this a user-facing change? If yes, give a description of this change to be included in the release notes. - [ ] Is this PR including examples changes? If yes, please remember to update [example documentation](https://github.com/microsoft/Olive/blob/main/docs/source/examples.md) in a follow-up PR. ## (Optional) Issue link
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.