Introduce output type/shape validation #17301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuslepukhin
commented
Aug 25, 2023
skottmckay
reviewed
Aug 29, 2023
edgchen1
reviewed
Aug 29, 2023
edgchen1
previously approved these changes
Aug 31, 2023
30a8ba3
skottmckay
approved these changes
Sep 5, 2023
edgchen1
approved these changes
Sep 5, 2023
yuslepukhin
added a commit
that referenced
this pull request
Nov 16, 2023
### Description Allow empty shapes and do not validate them for inputs/outputs at the InferenceSession::ValidateInputsOutputs(). ### Motivation and Context #17301 disallowed empty shapes. However, many models depend on them as a way to pass shapes of different ranks.
kleiti
pushed a commit
to kleiti/onnxruntime
that referenced
this pull request
Mar 22, 2024
### Description Validate outputs type and shapes. Make sure sparse initializers are taken into account. ### Motivation and Context ORT currently does not validate output types or shapes. Further, neither inputs or outputs take into account sparse initializers that are converted from dense. It is currently possible to pre-allocate a wrong type/shape buffer for output. Cc: @Craigacp
kleiti
pushed a commit
to kleiti/onnxruntime
that referenced
this pull request
Mar 22, 2024
…soft#18442) ### Description Allow empty shapes and do not validate them for inputs/outputs at the InferenceSession::ValidateInputsOutputs(). ### Motivation and Context microsoft#17301 disallowed empty shapes. However, many models depend on them as a way to pass shapes of different ranks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Validate outputs type and shapes. Make sure sparse initializers are taken into account.
Motivation and Context
ORT currently does not validate output types or shapes. Further, neither inputs or outputs take into account sparse initializers that are converted from dense.
It is currently possible to pre-allocate a wrong type/shape buffer for output.
Cc: @Craigacp