Skip to content

Fix TRT EP allocator memory leak #16552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chilo-ms merged 4 commits into from
Jul 5, 2023
Merged

Fix TRT EP allocator memory leak #16552

chilo-ms merged 4 commits into from
Jul 5, 2023

Conversation

@chilo-ms
Copy link
Contributor

@chilo-ms chilo-ms commented Jun 30, 2023

Fix memory leak issue which comes from TRT EP's allocator object not being released upon destruction.
Following is the log from valgrind:

==1911860== 100,272 (56 direct, 100,216 indirect) bytes in 1 blocks are definitely lost in loss record 1,751 of 1,832
==1911860==    at 0x483CFA3: operator new(unsigned long) (vg_replace_malloc.c:472)
==1911860==    by 0x315DC2: std::_MakeUniq<onnxruntime::OrtAllocatorImplWrappingIAllocator>::__single_object std::make_unique<onnxruntime::OrtAllocatorImplWrappingIAllocator, std::shared_ptr<onnxruntime::IAllocator> >(std::shared_ptr<onnxruntime::IAllocator>&&) (unique_ptr.h:857)
==1911860==    by 0x30EE7B: OrtApis::KernelContext_GetAllocator(OrtKernelContext const*, OrtMemoryInfo const*, OrtAllocator**) (custom_ops.cc:121)
==1911860==    by 0x660D115: onnxruntime::TensorrtExecutionProvider::Compile(std::vector<onnxruntime::IExecutionProvider::FusedNodeAndGraph, std::allocator<onnxruntime::IExecutionProvider::FusedNodeAndGraph> > const&, std::vector<onnxruntime::NodeComputeInfo, std::allocator<onnxruntime::NodeComputeInfo> >&)::{lambda(void*, OrtApi const*, OrtKernelContext*)#3}::operator()(void*, OrtApi const*, OrtKernelContext*) const (tensorrt_execution_provider.cc:2223)

This issue happens after this EP allocator refactor

@chilo-ms chilo-ms requested review from jslhcl and jywu-msft June 30, 2023 22:18
@chilo-ms chilo-ms marked this pull request as ready for review June 30, 2023 22:19
@chilo-ms chilo-ms merged commit d8792f8 into main Jul 5, 2023
@chilo-ms chilo-ms deleted the chi/fix_mem_leak branch July 5, 2023 16:25
yf711 added a commit that referenced this pull request Aug 7, 2023
@yf711
Revert "Fix TRT EP allocator memory leak (#16552)"
dd6b443 
This reverts commit d8792f8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jywu-msft jywu-msft jywu-msft approved these changes

@jslhcl jslhcl Awaiting requested review from jslhcl

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chilo-ms @jywu-msft