Skip to content

Use equals() for String comparisons instead of '==' and Remove unused imports#7

Merged
Suraiya-Hameed merged 4 commits intomicrosoft:devfrom
cosmofrit:master
Dec 2, 2016
Merged

Use equals() for String comparisons instead of '==' and Remove unused imports#7
Suraiya-Hameed merged 4 commits intomicrosoft:devfrom
cosmofrit:master

Conversation

@cosmofrit
Copy link
Copy Markdown
Contributor

Corrected some String comparisons to use equals() instead of '=='

@cosmofrit cosmofrit changed the title Use equals() for String comparisons instead of '==' Use equals() for String comparisons instead of '==' and Remove unused imports Nov 19, 2016
@YoungGah YoungGah added the Under Review Used for pull requests under review label Nov 22, 2016
Copy link
Copy Markdown
Contributor

@Suraiya-Hameed Suraiya-Hameed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cosmofrit, the changes look good! Can you please submit again by undoing the commit for unused imports? We are working on unused and wildcard imports for all the files, they will be checked in soon.

@cosmofrit
Copy link
Copy Markdown
Contributor Author

I've reverted the commit for unused imports

@Suraiya-Hameed Suraiya-Hameed merged commit 5b9e180 into microsoft:dev Dec 2, 2016
@Suraiya-Hameed
Copy link
Copy Markdown
Contributor

Thanks for your contribution.

rene-ye added a commit that referenced this pull request Jan 31, 2018
lilgreenbird pushed a commit to lilgreenbird/mssql-jdbc that referenced this pull request Aug 22, 2020
David-Engel pushed a commit to David-Engel/mssql-jdbc that referenced this pull request Oct 7, 2021
Handle cached end-of-streams from poll() calls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Under Review Used for pull requests under review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants