Skip to content

Change back 'sendTimeAsDatetime' property's default value to 'true'#616

Merged
cheenamalhotra merged 6 commits intodevfrom
preSendTime
Jan 31, 2018
Merged

Change back 'sendTimeAsDatetime' property's default value to 'true'#616
cheenamalhotra merged 6 commits intodevfrom
preSendTime

Conversation

@cheenamalhotra
Copy link
Copy Markdown
Member

@cheenamalhotra cheenamalhotra commented Jan 31, 2018

No description provided.

@cheenamalhotra cheenamalhotra requested a review from ulvii January 31, 2018 20:30
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 31, 2018 •
edited
Loading

Codecov Report

Merging #616 into dev will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #616      +/-   ##
============================================
+ Coverage     46.55%   46.58%   +0.03%     
+ Complexity     2229     2226       -3     
============================================
  Files           109      109              
  Lines         25409    25409              
  Branches       4184     4184              
============================================
+ Hits          11828    11837       +9     
+ Misses        11556    11542      -14     
- Partials       2025     2030       +5
Flag Coverage Δ Complexity Δ
#JDBC42 46.51% <100%> (+0.01%) 2224 <0> (-4) ⬇️
#JDBC43 46.5% <100%> (+0.05%) 2224 <0> (+2) ⬆️
Impacted Files Coverage Δ Complexity Δ
.../com/microsoft/sqlserver/jdbc/SQLServerDriver.java 76.85% <100%> (ø) 25 <0> (ø) ⬇️
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 47.19% <0%> (-1.13%) 17% <0%> (-1%)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 32.75% <0%> (-0.41%) 241% <0%> (-4%)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.61% <0%> (-0.2%) 239% <0%> (-1%)
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 62.44% <0%> (ø) 63% <0%> (-1%) ⬇️
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 45.67% <0%> (+0.03%) 278% <0%> (+2%) ⬆️
...m/microsoft/sqlserver/jdbc/SQLServerStatement.java 59.73% <0%> (+0.1%) 134% <0%> (+1%) ⬆️
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 63.2% <0%> (+0.12%) 0% <0%> (ø) ⬇️
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 61.35% <0%> (+0.43%) 89% <0%> (+1%) ⬆️
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 54.16% <0%> (+0.56%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5856172...d44a5f0. Read the comment docs.

@cheenamalhotra cheenamalhotra merged commit 6c79be8 into dev Jan 31, 2018
@cheenamalhotra cheenamalhotra added this to the 6.4.0 milestone Feb 1, 2018
@cheenamalhotra cheenamalhotra deleted the preSendTime branch February 26, 2018 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ulvii ulvii ulvii approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

6.4.0

Development

Successfully merging this pull request may close these issues.

5 participants

@cheenamalhotra @codecov-io @ulvii @lilgreenbird @rene-ye