Skip to content

Reverting PR 552#574

Merged
peterbae merged 3 commits intomicrosoft:devfrom
peterbae:github-477
Dec 7, 2017
Merged

Reverting PR 552#574
peterbae merged 3 commits intomicrosoft:devfrom
peterbae:github-477

Conversation

@peterbae
Copy link
Copy Markdown
Contributor

@peterbae peterbae commented Dec 7, 2017

Reverting Pr #552 due to test failures.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 7, 2017

Codecov Report

Merging #574 into dev will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #574      +/-   ##
============================================
+ Coverage     46.56%   46.59%   +0.02%     
+ Complexity     2221     2220       -1     
============================================
  Files           108      108              
  Lines         25340    25335       -5     
  Branches       4178     4177       -1     
============================================
+ Hits          11800    11804       +4     
+ Misses        11505    11501       -4     
+ Partials       2035     2030       -5
Flag Coverage Δ Complexity Δ
#JDBC41 46.34% <100%> (ø) 2204 <0> (-9) ⬇️
#JDBC42 46.39% <100%> (-0.04%) 2215 <0> (+2)
Impacted Files Coverage Δ Complexity Δ
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 33.14% <100%> (-0.3%) 245 <0> (-2)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.39% <0%> (-0.26%) 238% <0%> (-1%)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 63.05% <0%> (+0.06%) 0% <0%> (ø) ⬇️
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 53.89% <0%> (+0.26%) 0% <0%> (ø) ⬇️
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 44.92% <0%> (+0.9%) 104% <0%> (ø) ⬇️
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 52.59% <0%> (+1.48%) 12% <0%> (+1%) ⬆️
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 44.94% <0%> (+2.24%) 16% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fe90f7...557fdf3. Read the comment docs.

@peterbae peterbae merged commit ab733d3 into microsoft:dev Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants